Remove apiclientlib #486
Merged
Remove apiclientlib #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you meant to target this to main? |
Merged
niloc132
reviewed
Jul 21, 2024
| @@ -169,7 +168,7 @@ private static String getParametersString(Map<String, String> parametersMap) { | |||
| } | |||
| resultBuilder.append(entry.getKey()); | |||
| resultBuilder.append('='); | |||
| resultBuilder.append(ESCAPER.escape(entry.getValue())); | |||
| resultBuilder.append(URLEncoder.encode(entry.getValue(), Charsets.UTF_8)); | |||
There was a problem hiding this comment.
could also be java.nio.charset.StandardCharsets.UTF_8
|
protoism
force-pushed
the
feature/remove_apiclientlib
branch
from
b000046 to
3e95247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugin apiclientlib is used only for percent encoding.
I replaced google-http-java-client's
PercentEncoder with java's URLEncoder
So... apiclientlib can be removed