Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eclipse compilation #485

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Fix eclipse compilation #485

merged 2 commits into from
Jul 26, 2024

Conversation

protoism
Copy link
Contributor

@protoism protoism commented Jul 21, 2024 •
edited
Loading

After importing the project in Eclipse 2023-12:

  • Eclipse is complaining about this dependency from com.atlassw.tools.eclipse.checkstyle.CheckstyleBuilder which seems to be not available anymore on the store
  • Eclipse is complaining about some Jetty API, luckily in dead code (Jetty is currently provided by the Jetty SDK)

So....

  • Rebuilt eclipse project files from maven
  • Removed Jetty related dead code

As a matter of fact, it looks like there are quite a bit of versioned dependencies which are not needed anymore (entire com.gwtplugins.gdt.eclipse.apiclientlib). Next PR...

@protoism protoism requested review from niloc132 and foal July 21, 2024 17:02
niloc132
niloc132 reviewed Jul 21, 2024
View reviewed changes
Copy link
Member

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't confidently approve this without more eclipse experience, but if @foal doesn't have anything to add I'll approve, unblock #486.

@protoism
Copy link
Contributor Author

@niloc132 Please approve.
I'd consider disabling approval altogether

@protoism protoism requested a review from niloc132 July 25, 2024 09:28
@protoism protoism merged commit 17700e4 into main Jul 26, 2024
4 checks passed
@protoism protoism deleted the feature/fix_eclipse_compilation branch July 26, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foal foal Awaiting requested review from foal

@OneGeek OneGeek Awaiting requested review from OneGeek

@jhickman jhickman Awaiting requested review from jhickman

@branflake2267 branflake2267 Awaiting requested review from branflake2267

@JamesXNelson JamesXNelson Awaiting requested review from JamesXNelson

@turbomanage turbomanage Awaiting requested review from turbomanage

@ivmarkov ivmarkov Awaiting requested review from ivmarkov

@rdayal rdayal Awaiting requested review from rdayal

@niloc132 niloc132 Awaiting requested review from niloc132

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@protoism @niloc132