Updated Guava and javax.servlet dependencies

[keinhaar]

• Removed the included 2 guava libraries and replaced them by an dependency to the bundle com.google.guava which is included in eclipse anyway.
• replaced the javax.servlet dependency by jakarta.servlet-api, which is included since 2021-06.

[protoism]

Hi @keinhaar,
this PR seems interesting, but I wonder how safe is using Eclipse's guava.
I wonder if we introduce a dependency between the version we need, and the version eclipse distributes.
Moreover, we're "exporting" guava. What does it mean?

About servlet APIs... the proposed fix is already in main, isn't it?

So... at the very least the PR must be re-done (best thing to do in my opinion is back merging main branch to your branch and make a manual merge)

Let me know!

[protoism]

Hi Keinhaar.

There are just a handful binary libraries (except monster GWT dev)

• guava JDK 5 is probably gone, see Remove apiclientlib #486
• gson is not used
• Servlet APIs change is already in main (and probably can go away as well :)
• JSR 305 usage is too low to justify embedding the library

What's missing is Guava dependency.
As far as I now Guava people do care a lot about binary compatibility, so let's assume that all versions will do.
But nonetheless, can you point me to where Eclipse people declare that guava is part of all distributions, and safe to use?
At the very least, we must pay attention to how to declare guava dependency.
I don't even understand, for example (I beg pardon for my ignorance), where we would declare "we want guava from that Eclipse version"

[protoism]

Closing this PR.
I think we can simply remove all dependencies except GWT / Guava.
About Guava, I'm a bit reluctant to use the Eclipse provided version to reduce the risk of breaking the plugin with newer Eclipse releases