Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for MPC class using crocoddyl unicycle. #124

Open
wants to merge 4 commits into
base: topic/humble-devel/refactor
Choose a base branch
from

Conversation

jmirabel
Copy link

At the moment, I'm not entirely sure how to test the output of MPC.run.

@TheoMF can you point me to where this is used. I would like to write a unit test that matches that.

Copy link
Collaborator

@ArthurH91 ArthurH91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work. More questions than remarks on the code in the comments i left.

agimus_controller/tests/test_mpc_unicycle.py Show resolved Hide resolved
agimus_controller/tests/test_mpc_unicycle.py Show resolved Hide resolved
agimus_controller/tests/test_mpc_unicycle.py Outdated Show resolved Hide resolved
@TheoMF
Copy link
Collaborator

TheoMF commented Jan 20, 2025

At the moment, I'm not entirely sure how to test the output of MPC.run.

@TheoMF can you point me to where this is used. I would like to write a unit test that matches that.

sorry for the delay, in this main https://github.com/agimus-project/agimus_controller/blob/humble-devel/agimus_controller_examples/agimus_controller_examples/main/panda/main_hpp_mpc.py you have a mpc running over a trajectory with the previous classes of mpc and ocp, this main calls a functions mpc.simulate_mpc which uses the function mpc.mpc_step that is the equivalent to mpc.run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants