Tidy mess from initial TaskRecord implementation #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaskRecord was merged in PR #2392 from a separate development branch, and contained some cruft which this PR removes: * a comment on checkpoint, that was a note on that development branch, not relevant to the main codebase * retries_left was removed in #1773 and has never been used in TaskRecord * fn_has was removed in #1945 and has never been used in TaskRecord
khk-globus
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TaskRecord was merged in PR #2392 from a separate
development branch, and contained some cruft which this PR removes:
a comment on checkpoint, that was a note on that development branch, not relevant to the main codebase
retries_left was removed in Remove task record retries_left because it is no longer used #1773 and has never been used in TaskRecord
fn_has was removed in Memoize functions like any other value #1945 and has never been used in TaskRecord
Type of change