Skip to content

Commit

Permalink
Tidy mess from initial TaskRecord implementation (#3746)
Browse files Browse the repository at this point in the history
TaskRecord was merged in PR #2392 from a separate
development branch, and contained some cruft which this PR removes:

* a comment on checkpoint, that was a note on that development branch,
not relevant to the main codebase

* retries_left was removed in #1773 and has never been used in
TaskRecord

* fn_has was removed in #1945 and has never been used in TaskRecord

## Type of change

- Code maintenance/cleanup

Co-authored-by: Kevin Hunter Kesling <[email protected]>
  • Loading branch information
benclifford and khk-globus authored Jan 14, 2025
1 parent 9750976 commit f8c9cd1
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions parsl/dataflow/taskrecord.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,11 @@ class TaskRecord(TypedDict, total=False):
executed on.
"""

retries_left: int
fail_count: int
fail_cost: float
fail_history: List[str]

checkpoint: bool # this change is also in #1516
checkpoint: bool
"""Should this task be checkpointed?
"""

Expand All @@ -68,7 +67,6 @@ class TaskRecord(TypedDict, total=False):

# these three could be more strongly typed perhaps but I'm not thinking about that now
func: Callable
fn_hash: str
args: Sequence[Any]
# in some places we uses a Tuple[Any, ...] and in some places a List[Any].
# This is an attempt to correctly type both of those.
Expand Down

0 comments on commit f8c9cd1

Please sign in to comment.