Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy mess from initial TaskRecord implementation #3746

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Tidy mess from initial TaskRecord implementation #3746

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47e3bfe
Tidy mess from initial TaskRecord implementation
benclifford Jan 14, 2025
794aeed
Merge branch 'master' into benc-tidy-taskrecord
khk-globus Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions parsl/dataflow/taskrecord.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,11 @@ class TaskRecord(TypedDict, total=False):
executed on.
"""

retries_left: int
fail_count: int
fail_cost: float
fail_history: List[str]

checkpoint: bool # this change is also in #1516
checkpoint: bool
"""Should this task be checkpointed?
"""

Expand All @@ -68,7 +67,6 @@ class TaskRecord(TypedDict, total=False):

# these three could be more strongly typed perhaps but I'm not thinking about that now
func: Callable
fn_hash: str
args: Sequence[Any]
# in some places we uses a Tuple[Any, ...] and in some places a List[Any].
# This is an attempt to correctly type both of those.
Expand Down