-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mupdf: 1.23.0 -> 1.23.5; only build and install shared libraries #261113
mupdf: 1.23.0 -> 1.23.5; only build and install shared libraries #261113
Conversation
So, uh, it turns out pymupdf is broken on staging independent of this PR after it was bumped in the last python-updates cycle (my test builds were against these commits picked on top of master, so I didn't experience the breakage when running nixpkgs-review) It's not really related to this PR, but I'll probably still push a fix in the next day or so (but it can go in a new PR since it is orthogonal to this one, mostly) Edit: PyMuPDF is actually building from it's own vendored version right now anyway and can't use our MuPDF since it doesn't build C++ bindings... |
bfe4cac
to
295b90c
Compare
295b90c
to
5c5bee0
Compare
Okay so I've rebased this to fix a merge conflict, I added support for building the C++ and Python bindings to MuPDF and fixed PyMuPDF to use our own MuPDF build rather than building it's own I think I've untangled as much MuPDF stuff as I can at this point and I added myself as a maintainer for the package |
5c5bee0
to
37fe1d7
Compare
37fe1d7
to
1227757
Compare
Alright I've tried everything I could, so just writing my thoughts here in case someone has an idea. |
@happysalada That issue has nothing to do with pkg-config+leptonica (which works just fine if you actually test it) and has nothing to do with this PR. See #338680 (comment) |
Description of changes
Second attempt at #237199
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)