Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: llpp #260888

Closed
cafkafk opened this issue Oct 13, 2023 · 6 comments · Fixed by #260982
Closed

Build failure: llpp #260888

cafkafk opened this issue Oct 13, 2023 · 6 comments · Fixed by #260982
Labels
0.kind: build failure A package fails to build

Comments

@cafkafk
Copy link
Member

cafkafk commented Oct 13, 2023

Steps To Reproduce

Steps to reproduce the behavior:

  1. build llpp

Build log

https://0x0.st/H4J6.txt

Additional context

Works on 22.05

22.05 probably depends on insecure mupdf with:

       Known issues:
        - CVE-2020-26519: denial of service when parsing JBIG2
        - CVE-2017-5991: NULL pointer dereference

Notify maintainers

@pSub

Metadata

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.55, NixOS, 23.11 (Tapir), 23.11.20231008.2646b29`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.0`
 - channels(root): `"nixos"`
 - channels(ces): `"nixos-unstable, unstable"`
 - nixpkgs: `/nix/store/f01vs5kvjjxd870d55nqp0qxk251xjqv-source`
@cafkafk cafkafk added the 0.kind: build failure A package fails to build label Oct 13, 2023
@lilyinstarlight
Copy link
Member

I don't use this package, but I looked into it because why not I guess

It looks like it builds if you bump the AUR patch to the latest one but only if you also include #237199 (which fixes a derivation bug but was reverted because other packages in nixpkgs have workarounds that stopped working when the bug was fixed....)

@cafkafk
Copy link
Member Author

cafkafk commented Oct 14, 2023

ohh, thanks for looking at this! I build it with that version of mupdf and the aur patch, and it does build fine, but I get a runtime error now if run without arguments Fatal error: exception Invalid_argument("index out of bounds").

Still, it does seem able to open pdfs now, so it's sort of usable :p

@marsam marsam mentioned this issue Oct 14, 2023
12 tasks
@lilyinstarlight
Copy link
Member

I build it with that version of mupdf and the aur patch, and it does build fine, but I get a runtime error now if run without arguments Fatal error: exception Invalid_argument("index out of bounds").

Hmm I don't actually seem to get that error when running it without args 🤔

I don't actually know how to use this program though

@lilyinstarlight
Copy link
Member

I'll still merge #260982 in a bit to fix build for now, but I may have gotten sniped into taking #237199 back up again and will hopefully making a staging PR today (because we really should fix that....)

@cafkafk
Copy link
Member Author

cafkafk commented Oct 14, 2023

...but I may have gotten sniped into taking #237199 back up again...

Sorry! :p

@lilyinstarlight
Copy link
Member

Snipe is in #261113 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants