-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.pymupdf: 1.24.8 -> 1.24.9 #338680
python312Packages.pymupdf: 1.24.8 -> 1.24.9 #338680
Conversation
There's a build failure on Darwin... going to check it out. |
Issue introduced in #261113 |
here is the darwin failure in case it helps Running phase: unpackPhase coming from mupdf @fpletz |
I tried to fix it, without luck so far :( |
As I mentioned on Matrix, this was introduced in #332385 from it being untested on Darwin and not updating the Darwin patch for makefile changes in MuPDF 1.24 (apparently the patch "applied" but semantic correctness was not checked) It absolutely had nothing to do with that change, as evidenced by the Hydra build successes/failures for |
Sorry for the misdirection, and thank you for correcting me. Hope you're not offended. |
I'm not too particularly offended, it's okay :) You were trying your best (even if it was a bit misguided and I did get a little annoyed at first) <3 I'm just more worried about nixpkgs maintenance in general if me leaving is enough for these derivations to crumble like this |
Hmmm, i just tried moving the patch around, but it seems that something else is missing, it gives the same error. |
Done in #342894. |
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.pymupdf is: Python bindings for MuPDF's rendering library
meta.homepage for python312Packages.pymupdf is: https://github.com/pymupdf/PyMuPDF
meta.changelog for python312Packages.pymupdf is: https://github.com/pymupdf/PyMuPDF/releases/tag/1.24.9
Updates performed
To inspect upstream changes
Impact
Checks done
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
run on x86_64-linux 12 packages marked as broken and skipped:
4 packages failed to build:
22 packages built:
Maintainer pings
cc @teto for testing.
Tip
As a maintainer, if your package is located under
pkgs/by-name/*
, you can comment@NixOS/nixpkgs-merge-bot merge
to automatically merge this update using thenixpkgs-merge-bot
.Add a 👍 reaction to pull requests you find important.