Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pymupdf: 1.24.8 -> 1.24.9 #338680

Closed

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python312Packages.pymupdf is: Python bindings for MuPDF's rendering library

meta.homepage for python312Packages.pymupdf is: https://github.com/pymupdf/PyMuPDF

meta.changelog for python312Packages.pymupdf is: https://github.com/pymupdf/PyMuPDF/releases/tag/1.24.9

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.24.9 with grep in /nix/store/q259zsfjiyv87xi6pip7gnb0q4jlcyk7-python3.12-pymupdf-1.24.9
  • found 1.24.9 in filename of file in /nix/store/q259zsfjiyv87xi6pip7gnb0q4jlcyk7-python3.12-pymupdf-1.24.9

Rebuild report (if merged into master) (click to expand)
15 total rebuild path(s)

15 package rebuild(s)

First fifty rebuilds by attrpath

browsr
khoj
mcomix
python311Packages.llama-index
python311Packages.llama-index-readers-file
python311Packages.llama-index-readers-s3
python311Packages.pdf2docx
python311Packages.private-gpt
python311Packages.pymupdf
python311Packages.pytikz-allefeld
python312Packages.pdf2docx
python312Packages.pymupdf
python312Packages.pytikz-allefeld
termpdfpy
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/q259zsfjiyv87xi6pip7gnb0q4jlcyk7-python3.12-pymupdf-1.24.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python312Packages.pymupdf https://github.com/r-ryantm/nixpkgs/archive/e4c2ae9e505e7b5bac99b9ae2c1c39e9e497e020.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/e4c2ae9e505e7b5bac99b9ae2c1c39e9e497e020#python312Packages.pymupdf

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/q259zsfjiyv87xi6pip7gnb0q4jlcyk7-python3.12-pymupdf-1.24.9
ls -la /nix/store/q259zsfjiyv87xi6pip7gnb0q4jlcyk7-python3.12-pymupdf-1.24.9/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:
  • khoj
  • khoj.dist
4 packages failed to build:
  • python311Packages.pdf2docx
  • python311Packages.pdf2docx.dist
  • python312Packages.pdf2docx
  • python312Packages.pdf2docx.dist
22 packages built:
  • browsr
  • browsr.dist
  • mcomix
  • mcomix.dist
  • python311Packages.llama-index
  • python311Packages.llama-index-readers-file
  • python311Packages.llama-index-readers-file.dist
  • python311Packages.llama-index-readers-s3
  • python311Packages.llama-index-readers-s3.dist
  • python311Packages.llama-index.dist
  • python311Packages.private-gpt
  • python311Packages.private-gpt.dist
  • python311Packages.pymupdf
  • python311Packages.pymupdf.dist
  • python311Packages.pytikz-allefeld
  • python311Packages.pytikz-allefeld.dist
  • python312Packages.pymupdf
  • python312Packages.pymupdf.dist
  • python312Packages.pytikz-allefeld
  • python312Packages.pytikz-allefeld.dist
  • termpdfpy
  • termpdfpy.dist

Maintainer pings

cc @teto for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@drupol
Copy link
Contributor

drupol commented Sep 1, 2024

There's a build failure on Darwin... going to check it out.

@drupol drupol marked this pull request as draft September 1, 2024 19:06
@drupol drupol self-assigned this Sep 1, 2024
@drupol
Copy link
Contributor

drupol commented Sep 2, 2024

Issue introduced in #261113

@happysalada
Copy link
Contributor

here is the darwin failure in case it helps

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/yds0i2kafj6dmvhpg275wwwhymfgqq8b-mupdf-1.24.8-source.tar.gz
source root is mupdf-1.24.8-source
setting SOURCE_DATE_EPOCH to timestamp 1721817351 of file mupdf-1.24.8-source/thirdparty/tesseract.txt
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
applying patch /nix/store/nvmjz5f7hfilyx8p98g00ialvsp23y43-0002-Add-Darwin-deps.patch
patching file Makerules
Hunk #1 succeeded at 208 with fuzz 1 (offset 55 lines).
applying patch /nix/store/dw4z9fs6kl2fgm0fv6aqjnci09jg6kjl-0003-Fix-cpp-build.patch
patching file scripts/wrap/cpp.py
Hunk #1 succeeded at 5055 (offset 460 lines).
substituteStream() in derivation mupdf-1.24.8: WARNING: '--replace' is deprecated, use --replace-{fail,warn,quiet}. (file 'Makerules')
patching script interpreter paths in scripts/mupdfwrap.py
scripts/mupdfwrap.py: interpreter directive changed from "#! /usr/bin/env python3" to "/nix/store/ks8acr22s4iggnmvxydm5czl30racy32-python3-3.12.5/bin/python3"
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
fixing libtool script ./thirdparty/lcms2/ltmain.sh
./thirdparty/lcms2/configure
no configure script, doing nothing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
build flags: -j4 SHELL=/nix/store/gyp8mby6x8fljfm8f942w2mkyjdjk6pc-bash-5.2p32/bin/bash prefix=$(out) shared=yes USE_SYSTEM_LIBS=yes PKG_CONFIG=/nix/store/8y616797pbbagd1405prc1lwgc5p4r0y-pkg-config-wrapper-0.29.2/bin/pkg-config HAVE_X11=no USE_TESSERACT=yes
Makethird:57: *** missing separator. Stop.

coming from mupdf @fpletz

@drupol
Copy link
Contributor

drupol commented Sep 14, 2024

I tried to fix it, without luck so far :(

@lilyinstarlight
Copy link
Member

Issue introduced in #261113

As I mentioned on Matrix, this was introduced in #332385 from it being untested on Darwin and not updating the Darwin patch for makefile changes in MuPDF 1.24 (apparently the patch "applied" but semantic correctness was not checked)

It absolutely had nothing to do with that change, as evidenced by the Hydra build successes/failures for nixpkgs:trunk:python312Packages.pymupdf.aarch64-darwin

@drupol
Copy link
Contributor

drupol commented Sep 15, 2024

Issue introduced in #261113

As I mentioned on Matrix, this was introduced in #332385 from it being untested on Darwin and not updating the Darwin patch for makefile changes in MuPDF 1.24 (apparently the patch "applied" but semantic correctness was not checked)

Sorry for the misdirection, and thank you for correcting me. Hope you're not offended.

@lilyinstarlight
Copy link
Member

Sorry for the misdirection, and thank you for correcting me. Hope you're not offended.

I'm not too particularly offended, it's okay :)

You were trying your best (even if it was a bit misguided and I did get a little annoyed at first) <3

I'm just more worried about nixpkgs maintenance in general if me leaving is enough for these derivations to crumble like this

@happysalada
Copy link
Contributor

Hmmm, i just tried moving the patch around, but it seems that something else is missing, it gives the same error.
Thank you for information though.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@wegank
Copy link
Member

wegank commented Nov 1, 2024

Done in #342894.

@wegank wegank closed this Nov 1, 2024
@r-ryantm r-ryantm deleted the auto-update/python312Packages.pymupdf branch November 2, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants