orchestratord support alternative schedulers #30961
Merged
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pH14
reviewed
Jan 7, 2025
| @@ -224,6 +224,9 @@ rbac: | |||
| # -- Whether to create necessary RBAC roles and bindings | |||
| create: true | |||
|
|
|||
| # use a non-default kubernetes scheduler | |||
There was a problem hiding this comment.
let's use the -- notation to pull this into our generated docs, and can call out it's only needed when using a custom scheduler
alex-hunt-materialize
force-pushed
the
support_alternative_schedulers
branch
3 times, most recently
from
557d6a1 to
bcc5c5f
Compare
alex-hunt-materialize
force-pushed
the
support_alternative_schedulers
branch
from
bcc5c5f to
6261b8b
Compare
doy-materialize
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to the helm chart for alternative kubernetes schedulers.
Motivation
Part of the migration to using orchestratord in SaaS. We use a custom scheduler there.
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.