Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orchestratord support alternative schedulers #30961

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions misc/helm-charts/operator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ The following table lists the configurable parameters of the Materialize operato
| `operator.resources.requests` | Resources requested by the operator for CPU and memory | ``{"cpu":"100m","memory":"512Mi"}`` |
| `operator.secretsController` | Which secrets controller to use for storing secrets. Valid values are 'kubernetes' and 'aws-secrets-manager'. Setting 'aws-secrets-manager' requires a configured AWS cloud provider and IAM role for the environment with Secrets Manager permissions. | ``"kubernetes"`` |
| `rbac.create` | Whether to create necessary RBAC roles and bindings | ``true`` |
| `schedulerName` | Optionally use a non-default kubernetes scheduler. | ``nil`` |
| `serviceAccount.create` | Whether to create a new service account for the operator | ``true`` |
| `serviceAccount.name` | The name of the service account to be created | ``"orchestratord"`` |
| `storage.storageClass.allowVolumeExpansion` | | ``false`` |
Expand Down
3 changes: 3 additions & 0 deletions misc/helm-charts/operator/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -150,5 +150,8 @@ spec:
{{- end }}
{{- end }}
- "--enable-security-context"
{{- if .Values.schedulerName }}
- "--scheduler-name={{ .Values.schedulerName }}"
{{- end }}
resources:
{{- toYaml .Values.operator.resources | nindent 10 }}
14 changes: 14 additions & 0 deletions misc/helm-charts/operator/tests/deployment_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,17 @@ tests:
- contains:
path: spec.template.spec.containers[0].args
content: "--secrets-controller=aws-secrets-manager"

- it: should not pass the scheduler when not configured
asserts:
- notContains:
path: spec.template.spec.containers[0].args
content: "--scheduler-name"

- it: should pass the scheduler when configured
set:
schedulerName: my-scheduler
asserts:
- contains:
path: spec.template.spec.containers[0].args
content: "--scheduler-name=my-scheduler"
3 changes: 3 additions & 0 deletions misc/helm-charts/operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,9 @@ rbac:
# -- Whether to create necessary RBAC roles and bindings
create: true

# -- Optionally use a non-default kubernetes scheduler.
schedulerName: null

# Service account settings
serviceAccount:
# -- Whether to create a new service account for the operator
Expand Down
Loading