Skip to content

Commit

Permalink
orchestratord support alternative schedulers
Browse files Browse the repository at this point in the history
  • Loading branch information
alex-hunt-materialize committed Jan 7, 2025
1 parent ff4b6fd commit bcc5c5f
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 0 deletions.
1 change: 1 addition & 0 deletions misc/helm-charts/operator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ The following table lists the configurable parameters of the Materialize operato
| `operator.resources.limits` | Resource limits for the operator's CPU and memory | ``{"memory":"512Mi"}`` |
| `operator.resources.requests` | Resources requested by the operator for CPU and memory | ``{"cpu":"100m","memory":"512Mi"}`` |
| `rbac.create` | Whether to create necessary RBAC roles and bindings | ``true`` |
| `schedulerName` | Optionally use a non-default kubernetes scheduler. | ``nil`` |
| `serviceAccount.create` | Whether to create a new service account for the operator | ``true`` |
| `serviceAccount.name` | The name of the service account to be created | ``"orchestratord"`` |
| `storage.storageClass.allowVolumeExpansion` | | ``false`` |
Expand Down
3 changes: 3 additions & 0 deletions misc/helm-charts/operator/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -148,5 +148,8 @@ spec:
- "--segment-client-side"
{{- end }}
{{- end }}
{{- if .Values.schedulerName }}
- "--scheduler-name={{ .Values.schedulerName }}"
{{- end }}
resources:
{{- toYaml .Values.operator.resources | nindent 10 }}
14 changes: 14 additions & 0 deletions misc/helm-charts/operator/tests/deployment_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -161,3 +161,17 @@ tests:
- contains:
path: spec.template.spec.containers[0].args
content: "--console-image-tag-map=v0.126.0=25.2.0"

- it: should not pass the scheduler when not configured
asserts:
- notContains:
path: spec.template.spec.containers[0].args
content: "--scheduler-name"

- it: should pass the scheduler when configured
set:
schedulerName: my-scheduler
asserts:
- contains:
path: spec.template.spec.containers[0].args
content: "--scheduler-name=my-scheduler"
3 changes: 3 additions & 0 deletions misc/helm-charts/operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,9 @@ rbac:
# -- Whether to create necessary RBAC roles and bindings
create: true

# -- Optionally use a non-default kubernetes scheduler.
schedulerName: null

# Service account settings
serviceAccount:
# -- Whether to create a new service account for the operator
Expand Down

0 comments on commit bcc5c5f

Please sign in to comment.