Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support zephyr for SOF on i.MX8ULP #63751

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Support zephyr for SOF on i.MX8ULP #63751

merged 4 commits into from
Dec 4, 2023

Conversation

TangleZ
Copy link

@TangleZ TangleZ commented Oct 10, 2023

Add support for i.MX8ULP to build Sound Open Firmware with Zephyr OS on DSP.
The build target is i.MX8ULP. It has one Xtensa HiFi4 core, with 64 KB ITCM, and 64KB DTCM.

Causing the toolchain not be ready, so the code not been tested in local so far.

@zephyrbot zephyrbot added area: West West utility platform: NXP NXP area: Xtensa Xtensa Architecture labels Oct 10, 2023
@github-actions
Copy link

Hello @TangleZ, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@iuliana-prodan
Copy link
Collaborator

Please, solve compliance checks: https://github.com/zephyrproject-rtos/zephyr/actions/runs/6469020912/job/17563186840?pr=63751

@iuliana-prodan iuliana-prodan mentioned this pull request Oct 12, 2023
Merged
@TangleZ TangleZ force-pushed the main branch 2 times, most recently from d7c6f88 to a66cefb Compare November 3, 2023 06:41
LaurentiuM1234
LaurentiuM1234 reviewed Nov 3, 2023
View reviewed changes
boards/xtensa/nxp_adsp_imx8ulp/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/xtensa/nxp_adsp_imx8ulp/Kconfig.defconfig Outdated Show resolved Hide resolved
boards/xtensa/nxp_adsp_imx8ulp/nxp_adsp_imx8ulp_defconfig Outdated Show resolved Hide resolved
boards/xtensa/nxp_adsp_imx8ulp/nxp_adsp_imx8ulp_defconfig Outdated Show resolved Hide resolved
boards/xtensa/nxp_adsp_imx8ulp/nxp_adsp_imx8ulp_defconfig Outdated Show resolved Hide resolved
boards/xtensa/nxp_adsp_imx8ulp/nxp_adsp_imx8ulp_defconfig Outdated Show resolved Hide resolved
soc/xtensa/nxp_adsp/imx8ulp/Kconfig.defconfig.series Show resolved Hide resolved
soc/xtensa/nxp_adsp/imx8ulp/Kconfig.defconfig.series Outdated Show resolved Hide resolved
soc/xtensa/nxp_adsp/imx8ulp/Kconfig.defconfig.series Outdated Show resolved Hide resolved
soc/xtensa/nxp_adsp/imx8ulp/include/soc/memory.h Outdated Show resolved Hide resolved
@TangleZ
Copy link
Author

TangleZ commented Nov 8, 2023

Not sure I understand why CONFIG_IMX_EDMA and CONFIG_DUMMY_DMA are still kept. Otherwise, LGTM.

I referred the patch https://github.com/zephyrproject-rtos/zephyr/pull/62974/files#diff-43afd304a697d5b80f682e1e3e0a2a4e0950d5fb8b2fec9c275e24d080576ab9 from you, and there are still keep EDMA and DUMMY config. So I guess it's ok for ulp.

@LaurentiuM1234
Copy link
Collaborator

Not sure I understand why CONFIG_IMX_EDMA and CONFIG_DUMMY_DMA are still kept. Otherwise, LGTM.

I referred the patch https://github.com/zephyrproject-rtos/zephyr/pull/62974/files#diff-43afd304a697d5b80f682e1e3e0a2a4e0950d5fb8b2fec9c275e24d080576ab9 from you, and there are still keep EDMA and DUMMY config. So I guess it's ok for ulp.

My bad, missed them. I've updated my PR to remove them as well.

iuliana-prodan
iuliana-prodan previously approved these changes Nov 9, 2023
View reviewed changes
@TangleZ TangleZ force-pushed the main branch 3 times, most recently from 3278c9e to fde4df2 Compare November 9, 2023 13:26
@iuliana-prodan iuliana-prodan mentioned this pull request Nov 13, 2023
Merged
stephanosio added a commit to iuliana-prodan/sdk-ng that referenced this pull request Nov 13, 2023
@stephanosio
ci: Disable testing of nxp_adsp_imx8ulp
3b9e9bf 
This commit disables the testing of `nxp_adsp_imx8ulp` platform
because it has not been merged upstream yet.

Re-enable this platform when the zephyrproject-rtos/zephyr#63751 is
merged.

Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio added a commit to zephyrproject-rtos/sdk-ng that referenced this pull request Nov 13, 2023
@stephanosio
ci: Disable testing of nxp_adsp_imx8ulp
dc574db 
This commit disables the testing of `nxp_adsp_imx8ulp` platform
because it has not been merged upstream yet.

Re-enable this platform when the zephyrproject-rtos/zephyr#63751 is
merged.

Signed-off-by: Stephanos Ioannidis <[email protected]>
@TangleZ
Copy link
Author

TangleZ commented Nov 14, 2023

@iuliana-prodan I noticed that PR zephyrproject-rtos/sdk-ng#712 is already merged, but the CI still fails, have we missed anything?

@dbaluta
Copy link
Collaborator

dbaluta commented Nov 14, 2023 •
edited
Loading

@TangleZ we still need CI & Zephyr to use the new SDK. As per @stephanosio instructions - the new SDK release will be available around Wednesday!

@iuliana-prodan
Copy link
Collaborator

@iuliana-prodan I noticed that PR zephyrproject-rtos/sdk-ng#712 is already merged, but the CI still fails, have we missed anything?

@TangleZ we need a zephyr sdk release that includes the toolchain for 8ulp.

@stephanosio will there be a sdk soon?
I believe that if we don't have the CI passing for this PR, with 8ulp support, it will not be merged.

@stephanosio
Copy link
Member

@stephanosio will there be a sdk soon?
I believe that if we don't have the CI passing for this PR, with 8ulp support, it will not be merged.

Yes, Zephyr SDK 0.16.4 should be released by Wednesday. Integrating it to the Zephyr main CI will take longer though.

@TangleZ
Copy link
Author

TangleZ commented Nov 20, 2023

@stephanosio How can I know if the SDK merged to Zephyr main CI or not? And should I retrigger the PR to run the CI test?

@iuliana-prodan iuliana-prodan mentioned this pull request Nov 20, 2023
Merged
@dleach02 dleach02 assigned dbaluta and unassigned dleach02 Nov 30, 2023
Zhang Peng added 4 commits December 1, 2023 11:36
boards: xtensa: adsp: add support for imx8ulp board
cfb68f8 
Add support for i.MX8ULP board by defining defconfig,
board configuration and device tree.

Signed-off-by: Zhang Peng <[email protected]>
dts/xtensa/nxp: Add dtsi for imx8ulp
a9a0c28 
Add file nxp_imx8ulp.dtsi for imx8ulp

Signed-off-by: Zhang Peng <[email protected]>
soc: xtensa: adsp: add support for NXP ADSP for i.MX8ULP
4b33c65 
Add support for i.MX8ULP target.

Signed-off-by: Zhang Peng <[email protected]>
west: sign: add support for NXP i.MX8ULP board
ceae1d8 
Add support for signing i.MX8ULP SOF with Zephyr images with rimage.

Signed-off-by: Zhang Peng <[email protected]>
@dbaluta
Copy link
Collaborator

dbaluta commented Dec 4, 2023

LGTM. @dleach02 good to merge.

@fabiobaltieri fabiobaltieri merged commit a47aa23 into zephyrproject-rtos:main Dec 4, 2023
33 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Hi @TangleZ!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentiuM1234 LaurentiuM1234 LaurentiuM1234 left review comments

@iuliana-prodan iuliana-prodan iuliana-prodan approved these changes

@dbaluta dbaluta dbaluta approved these changes

@mbolivar-ampere mbolivar-ampere Awaiting requested review from mbolivar-ampere

@nashif nashif Awaiting requested review from nashif

@dcpleung dcpleung Awaiting requested review from dcpleung

@andyross andyross Awaiting requested review from andyross

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@decsny decsny Awaiting requested review from decsny

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@dleach02 dleach02 Awaiting requested review from dleach02

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@manuargue manuargue Awaiting requested review from manuargue

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@yvanderv yvanderv Awaiting requested review from yvanderv

Assignees

@dbaluta dbaluta

Labels
area: West West utility area: Xtensa Xtensa Architecture platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@TangleZ @iuliana-prodan @LaurentiuM1234 @dbaluta @stephanosio @fabiobaltieri @zephyrbot @dleach02