refactor: normal creator

[phillebaba]

Description

This change refactors the package creation.

Related Issue

Relates to #2969

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[netlify]

✅ Deploy Preview for zarf-docs ready!

Name	Link
🔨 Latest commit	8df4a70
🔍 Latest deploy log	https://app.netlify.com/sites/zarf-docs/deploys/677fdfeca67c43000854bbcd
😎 Deploy Preview	https://deploy-preview-3114--zarf-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Attention: Patch coverage is 18.70504% with 1017 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/internal/packager2/layout/create.go	3.83%	445 Missing and 6 partials ⚠️
src/internal/packager2/actions/actions.go	0.00%	223 Missing ⚠️
src/internal/packager2/layout/sbom.go	9.50%	213 Missing and 6 partials ⚠️
src/internal/packager2/create.go	0.00%	40 Missing ⚠️
src/internal/packager2/filters/deploy.go	76.85%	23 Missing and 5 partials ⚠️
src/internal/packager2/layout/package.go	0.00%	28 Missing ⚠️
src/cmd/package.go	0.00%	13 Missing ⚠️
src/internal/packager2/layout/oci.go	0.00%	8 Missing ⚠️
src/internal/packager2/filters/diff.go	84.61%	4 Missing and 2 partials ⚠️
src/internal/packager2/layout/import.go	83.33%	0 Missing and 1 partial ⚠️

Files with missing lines	Coverage Δ
src/internal/packager2/filters/empty.go	100.00% <100.00%> (ø)
src/internal/packager2/filters/os.go	100.00% <100.00%> (ø)
src/internal/packager2/filters/select.go	100.00% <100.00%> (ø)
src/internal/packager2/filters/strat.go	100.00% <100.00%> (ø)
src/internal/packager2/filters/utils.go	100.00% <100.00%> (ø)
src/internal/packager2/layout/import.go	14.50% <83.33%> (+0.51%)	⬆️
src/internal/packager2/filters/diff.go	84.61% <84.61%> (ø)
src/internal/packager2/layout/oci.go	22.44% <0.00%> (-0.47%)	⬇️
src/cmd/package.go	0.00% <0.00%> (ø)
src/internal/packager2/filters/deploy.go	76.85% <76.85%> (ø)
... and 5 more

[AustinAbro321]

Generally looks good. I do request that we keep the Package saved to "zarf-init-amd64-v0.43.0.tar.zst" message we have currently.

I know we're trying to limit output for non errors, but I think the package tar path is worth logging since the filename isn't intuitive. It's a combination of whether it's an init or package config, amd or arm64, and the version. As a user I've found it useful to copy + paste the name from terminal when my next step is to publish or deploy, especially when I have multiple packages in the same directory.

[phillebaba]

I have now added back the logging for the path the package is saved to.

[AustinAbro321]

Ah so by using the maps.clone it creates a shallow copy so when the next component in the for loop comes by it doesn't have the sibling branches on it. Very neat!