Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Helm Chart for WSO2 API Microgateway Deployment #21
base: 3.2.0
Are you sure you want to change the base?
Introduce Helm Chart for WSO2 API Microgateway Deployment #21
Changes from 4 commits
c36883c
338c3c7
5b85281
0c9c954
98b604b
17b0b46
f038568
300e209
a3aa5d8
a3d786e
f9a1f68
5a7cf5f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chathuraswso2 Please refer to the README documentation and fix this doc with instructions for running in different versions of Helm and etc.
@ThilinaManamgoda do we have to provide instructions for running this with the pipeline rather than independently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 5a7cf5f commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThilinaManamgoda are there any real benefits of deploying this chart outside of the Kubernetes Pipeline?
If it is tightly coupled with the pipeline, shouldn't we be instructing the user to use this chart together with it?
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chathuraswso2 let's get rid of
minReadySeconds
property as it is not required in the Deployment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chathuraswso2 did you test the chart with the WSO2 Kubernetes Pipeline? What is the version which you used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't check with any Kubernetes Pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThilinaManamgoda shouldn't we test this chart with the WSO2 Kubernetes Pipeline and update the necessary sample repositories? Please correct me if I am wrong.