Introduce Helm Chart for WSO2 API Microgateway Deployment #21
Conversation
| deployment patterns are compatible with NGINX Ingress Controller Git release [`nginx-0.22.0`](https://github.com/kubernetes/ingress-nginx/releases/tag/nginx-0.22.0). | ||
|
|
||
|
|
||
| ## Quick Start Guide |
There was a problem hiding this comment.
@chathuraswso2 Please refer to the README documentation and fix this doc with instructions for running in different versions of Helm and etc.
@ThilinaManamgoda do we have to provide instructions for running this with the pipeline rather than independently?
There was a problem hiding this comment.
@ThilinaManamgoda are there any real benefits of deploying this chart outside of the Kubernetes Pipeline?
If it is tightly coupled with the pipeline, shouldn't we be instructing the user to use this chart together with it?
WDYT?
| ``` | ||
|
|
||
| dependencies: |
There was a problem hiding this comment.
@chathuraswso2 did you test the chart with the WSO2 Kubernetes Pipeline? What is the version which you used?
There was a problem hiding this comment.
Didn't check with any Kubernetes Pipeline.
There was a problem hiding this comment.
@ThilinaManamgoda shouldn't we test this chart with the WSO2 Kubernetes Pipeline and update the necessary sample repositories? Please correct me if I am wrong.
| | `wso2.deployment.wso2microgw.imageName` | Image name for microgateway node | "" | | ||
| | `wso2.deployment.wso2microgw.imageTag` | Image tag for microgateway node | "" | | ||
| | `wso2.deployment.wso2microgw.replicas` | Number of replicas for microgateway node | 1 | | ||
| | `wso2.deployment.wso2microgw.minReadySeconds` | Refer to [doc](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.10/#deploymentspec-v1-apps)| 1 75 | |
There was a problem hiding this comment.
@chathuraswso2 let's get rid of minReadySeconds property as it is not required in the Deployment.
| deployment patterns are compatible with NGINX Ingress Controller Git release [`nginx-0.22.0`](https://github.com/kubernetes/ingress-nginx/releases/tag/nginx-0.22.0). | ||
|
|
||
|
|
||
| ## Quick Start Guide |
There was a problem hiding this comment.
@ThilinaManamgoda are there any real benefits of deploying this chart outside of the Kubernetes Pipeline?
If it is tightly coupled with the pipeline, shouldn't we be instructing the user to use this chart together with it?
WDYT?
| ``` | ||
|
|
||
| dependencies: |
There was a problem hiding this comment.
@ThilinaManamgoda shouldn't we test this chart with the WSO2 Kubernetes Pipeline and update the necessary sample repositories? Please correct me if I am wrong.
|
@ThilinaManamgoda @chathuraswso2 please refer to the #19 for the pipeline tasks if this is applicable. |
Fix below issues,