Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate examples to notebooks #229

Merged
merged 75 commits into from
Jan 17, 2024
Merged

Migrate examples to notebooks #229

merged 75 commits into from
Jan 17, 2024

Conversation

waltsims
Copy link
Owner

closes #228

@waltsims waltsims self-assigned this Dec 15, 2023
@waltsims waltsims marked this pull request as draft December 15, 2023 18:10
@waltsims waltsims changed the title [WIP] Migrate examples to notebooks Migrate examples to notebooks Dec 15, 2023
@waltsims
Copy link
Owner Author

waltsims commented Dec 16, 2023 •
edited
Loading

- [ ] Add pull request template

  • Hide contributing.md in .github directory to clean up the root directory
  • Describe how and where to add google collab or other notebook links

@waltsims
Copy link
Owner Author

waltsims commented Dec 18, 2023 •
edited
Loading

  • update simulated data file on Google Drive and respective hash in code. Thanks @faridyagubbayli

@waltsims
Copy link
Owner Author

waltsims commented Dec 21, 2023 •
edited
Loading

  • update Readme example section

@waltsims
Copy link
Owner Author

This closes #192 by removing custom reconstruction code.

@faridyagubbayli
Copy link
Collaborator

@waltsims here is the new hash: 1lGFTifpOrzBYT4Bl_ccLu_Kx0IDxM0Lv (corresponds to the updated sensor data file here).

@waltsims
Copy link
Owner Author

  • update branch name in colab links to master before merging

@waltsims waltsims mentioned this pull request Jan 15, 2024
Closed
@waltsims waltsims requested a review from djps January 15, 2024 19:11
@waltsims waltsims linked an issue Jan 16, 2024 that may be closed by this pull request
Out-of-the-box usage #192
Closed
djps
djps approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@djps djps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the unresolved comment is minor.

@waltsims waltsims merged commit 35fe983 into master Jan 17, 2024
22 checks passed
@waltsims waltsims deleted the migrate-examples-to-notebooks branch January 17, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djps djps djps approved these changes

@faridyagubbayli faridyagubbayli Awaiting requested review from faridyagubbayli

Assignees

@waltsims waltsims

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@waltsims @faridyagubbayli @djps