Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear up deprication warning #253

Closed
waltsims opened this issue Jan 15, 2024 · 1 comment · Fixed by #289 or #318
Closed

Clear up deprication warning #253

waltsims opened this issue Jan 15, 2024 · 1 comment · Fixed by #289 or #318
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@waltsims
Copy link
Owner

waltsims commented Jan 15, 2024

WARNING:root:DeprecationWarning: Attributes will soon be typed when saved and not saved

#229 (comment)

The offending line of code can be found here.

@waltsims waltsims added the enhancement New feature or request label Jan 15, 2024
@faridyagubbayli faridyagubbayli added this to the v0.3.2 milestone Jan 25, 2024
@faridyagubbayli faridyagubbayli self-assigned this Jan 25, 2024
@waltsims
Copy link
Owner Author

waltsims commented Feb 4, 2024

          #289 is not compatible with binary execution:

┌───────────────────────────────────────────────────────────────┐
│                  kspaceFirstOrder-CUDA v1.3                   │
├───────────────────────────────────────────────────────────────┤
│ Reading simulation configuration:                      Failed │
└───────────────────────────────────────────────────────────────┘
┌───────────────────────────────────────────────────────────────┐
│            !!! K-Wave experienced a fatal error !!!           │
├───────────────────────────────────────────────────────────────┤
│ Error: Cannot read from attribute file_type in dataset [/.]:    │
│        iostream error                                         │
├───────────────────────────────────────────────────────────────┤
│                      Execution terminated                     │
└───────────────────────────────────────────────────────────────┘

reverting until this is fixed

Originally posted by @waltsims in #292 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants