Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure: Bumps stylelint from 15.1.0 to 16.8.0, stylelint-config-standard from 30.0.1 to 36.0.1 and use recommended rule #2853

Closed
wants to merge 8 commits into from
Closed

Infrastructure: Bumps stylelint from 15.1.0 to 16.8.0, stylelint-config-standard from 30.0.1 to 36.0.1 and use recommended rule #2853

wants to merge 8 commits into from

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Nov 1, 2023 •
edited by daniel-montalvo
Loading

Supersedes #2846

This updates stylelint which has a newly enforced rule, declaration-block-no-redundant-longhand-properties which is forcing instances of top: a, right: b, bottom: c, left: d to now be in the shorthand format of inset: a b c d.

For example, instances of the following:

top: 0;
right: 0;
left: 0;
bottom;

has been changed to:

inset: 0;

Following the Code Guide on shorthand notation, this seems to be the appropriate change to make.

WAI Preview Link (Last built on Wed, 31 Jul 2024 16:18:25 GMT).

@howard-e howard-e added Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation dependencies Pull requests that update a dependency file in a third-party package labels Nov 1, 2023
@howard-e howard-e requested review from mcking65 and a11ydoer November 1, 2023 20:00
@howard-e howard-e changed the title Infrastructure: Bumps stylelint from 15.1.0 to 15.11.0 and use recommended rules Infrastructure: Bumps stylelint from 15.1.0 to 15.11.0 and use recommended rule Nov 1, 2023
@michael-n-cooper-bot michael-n-cooper-bot mentioned this pull request Nov 1, 2023
Closed
a11ydoer
a11ydoer approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@a11ydoer a11ydoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for version update and code update. @howard-e

@evmiguel evmiguel mentioned this pull request Mar 18, 2024
Closed
@nschonni nschonni mentioned this pull request May 7, 2024
Merged
@howard-e howard-e force-pushed the update-stylelint-15.11.0 branch from 9ee3b8a to c13b1d2 Compare June 3, 2024 18:29
@howard-e howard-e changed the title Infrastructure: Bumps stylelint from 15.1.0 to 15.11.0 and use recommended rule Infrastructure: Bumps stylelint from 15.1.0 to 16.8.0, stylelint-config-standard from 30.0.1 to 36.0.1 and use recommended rule Jul 31, 2024
@nschonni nschonni mentioned this pull request Jul 31, 2024
Merged
@howard-e
Copy link
Contributor Author

Superseded by #3082

@howard-e howard-e closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a11ydoer a11ydoer a11ydoer approved these changes

@mcking65 mcking65 Awaiting requested review from mcking65

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file in a third-party package Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howard-e @a11ydoer