Infrastructure: Use Stylelint GitHub Action matcher #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
force-pushed
the
stylelint-github-matcher
branch
from
06405ba to
d12cac2
Compare
|
I don't know anything about the new commands. What are the reasons for and benefits of this diff? |
|
Similar to the old extra problem matcher, it will show a comment on the Files tab of PRs when there are issues. The benefit of swapping out the current one, is that one supported by Stylelint directly, should be kept up to date if they change any of their output format. This doesn't affect you running anything locally |
howard-e
added
the
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw on a different repo that they've added their own built-in formatter. Could't just add
npm run lint:css -f githubbecause it confused Prettier, so just split the tasks in the CI config.