Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] factoring out MambaMixer out of Jamba #8993

Merged
merged 5 commits into from
Nov 4, 2024
Merged

[Model] factoring out MambaMixer out of Jamba #8993

merged 5 commits into from
Nov 4, 2024

Conversation

mzusman
Copy link
Contributor

@mzusman mzusman commented Oct 1, 2024 •
edited
Loading

Factor out Mamba from Jamba to provide broader support for other Mamba-based models and enable future integration of the Mamba cache mechanism into the vLLM engine, alongside the KV cache.

CC @tlrmchlsmth

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify Mergify
Copy link

mergify bot commented Oct 30, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @mzusman please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mzusman mzusman force-pushed the mamba_factor_out branch 2 times, most recently from 0eb1b2a to 5c3b06f Compare November 3, 2024 17:22
@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 3, 2024
@mergify Mergify
Copy link

mergify bot commented Nov 3, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @mzusman please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mzusman
WIP - factor out mamba
ee13d1f 
Signed-off-by: mzusman <[email protected]>
@mergify mergify bot removed the needs-rebase label Nov 3, 2024
@mzusman
Add mixer to jamba
b5f3e32 
Signed-off-by: mzusman <[email protected]>
@mzusman mzusman marked this pull request as ready for review November 3, 2024 17:36
tlrmchlsmth
tlrmchlsmth approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 4, 2024
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) November 4, 2024 16:44
@tlrmchlsmth tlrmchlsmth merged commit 603a661 into vllm-project:main Nov 4, 2024
73 checks passed
@tlrmchlsmth tlrmchlsmth mentioned this pull request Nov 4, 2024
Merged
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@mzusman
[Model] factoring out MambaMixer out of Jamba (vllm-project#8993)
45995eb 
Signed-off-by: mzusman <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@mzusman
[Model] factoring out MambaMixer out of Jamba (vllm-project#8993)
c9ebd5a 
Signed-off-by: mzusman <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Nov 4, 2024
@mzusman @richardsliu
[Model] factoring out MambaMixer out of Jamba (vllm-project#8993)
db45c39 
Signed-off-by: mzusman <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
bigPYJ1151 pushed a commit to bigPYJ1151/vllm that referenced this pull request Nov 5, 2024
@mzusman @bigPYJ1151
[Model] factoring out MambaMixer out of Jamba (vllm-project#8993)
0250af5 
Signed-off-by: mzusman <[email protected]>
DarkLight1337 pushed a commit that referenced this pull request Nov 5, 2024
@mzusman @DarkLight1337
[Model] factoring out MambaMixer out of Jamba (#8993)
9b96883 
Signed-off-by: mzusman <[email protected]>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@mzusman @JC1DA
[Model] factoring out MambaMixer out of Jamba (vllm-project#8993)
18f767f 
Signed-off-by: mzusman <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@mzusman @sumitd2
[Model] factoring out MambaMixer out of Jamba (vllm-project#8993)
643adfb 
Signed-off-by: mzusman <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@mzusman
[Model] factoring out MambaMixer out of Jamba (vllm-project#8993)
707e704 
Signed-off-by: mzusman <[email protected]>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@mzusman @mfournioux
[Model] factoring out MambaMixer out of Jamba (vllm-project#8993)
b502ba4 
Signed-off-by: mzusman <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@mzusman @tlrmchlsmth
[Model] factoring out MambaMixer out of Jamba (vllm-project#8993)
bb37ad9 
Signed-off-by: mzusman <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@mzusman
[Model] factoring out MambaMixer out of Jamba (vllm-project#8993)
6f45fa6 
Signed-off-by: mzusman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

Assignees
No one assigned
Labels
ci/build documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzusman @tlrmchlsmth