Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(smart-contracts): lower contract size for PublicLock v15 #14846

Merged
merged 33 commits into from
Oct 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
0d1c190
remmove `addLockManager` helper
clemsos Oct 16, 2024
5e03d28
make `schemaVersion` internal
clemsos Oct 16, 2024
06ef523
cleanup migration code
clemsos Oct 16, 2024
9184fc3
introduce `_isValidHook` helper
clemsos Oct 17, 2024
c00400a
group into `hooks` single getter
clemsos Oct 17, 2024
48df1c8
cleanup interface
clemsos Oct 17, 2024
a7c0606
fix renounce lock manager on deploy
clemsos Oct 17, 2024
6ee3146
remove `setApprovalForAll` and `isApprovedForAll`
clemsos Oct 17, 2024
728d792
Merge branch 'master' into lower-lock-contract-size-v15
clemsos Oct 18, 2024
c1006ef
use `revokeRole` instead of `renounceRole`
clemsos Oct 18, 2024
36c37d3
Merge branch 'lower-lock-contract-size-v15' of github.com:unlock-prot…
clemsos Oct 18, 2024
23c3d23
Revert "group into `hooks` single getter"
clemsos Oct 18, 2024
89c68db
Revert "cleanup interface"
clemsos Oct 18, 2024
06ab7e5
remove unwanted func from interfaces
clemsos Oct 18, 2024
dac3fd4
use LOCK_MANAGER_ROLE in tests
clemsos Oct 18, 2024
f29b979
remove `schemaVersion` functions from interface
clemsos Oct 18, 2024
fe8937e
replace `renouceLockManager` in tests
clemsos Oct 18, 2024
45e388c
Merge branch 'master' into lower-lock-contract-size-v15
clemsos Oct 28, 2024
0493213
remove `setApprovalForAll` from tests
clemsos Oct 28, 2024
9557b9e
`addRole` should be `grantRole`
clemsos Oct 28, 2024
67bf41e
add roles to hardhat helpers
clemsos Oct 28, 2024
880454b
fix tests
clemsos Oct 28, 2024
c837a96
Merge branch 'lower-lock-contract-size-v15' of github.com:unlock-prot…
clemsos Oct 28, 2024
1faeb03
Merge branch 'master' into lower-lock-contract-size-v15
clemsos Oct 28, 2024
c1c6081
fix roles export
clemsos Oct 28, 2024
eaceed0
Merge branch 'lower-lock-contract-size-v15' of github.com:unlock-prot…
clemsos Oct 28, 2024
fe44f5f
Merge branch 'master' into lower-lock-contract-size-v15
clemsos Oct 28, 2024
d1d4f60
fix default lock manager role on deploy
clemsos Oct 30, 2024
c418935
Merge branch 'lower-lock-contract-size-v15' of github.com:unlock-prot…
clemsos Oct 30, 2024
68652e6
Merge branch 'master' into lower-lock-contract-size-v15
clemsos Oct 30, 2024
64d42a2
fix test
clemsos Oct 30, 2024
ef57196
Merge branch 'lower-lock-contract-size-v15' of github.com:unlock-prot…
clemsos Oct 30, 2024
bca6c23
fix extra txs tests
clemsos Oct 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remmove addLockManager helper
  • Loading branch information
clemsos committed Oct 16, 2024
commit 0d1c190a86e3daad38675654de580a4cb38a18b1
11 changes: 0 additions & 11 deletions smart-contracts/contracts/mixins/MixinRoles.sol
Original file line number Diff line number Diff line change
@@ -46,16 +46,5 @@ contract MixinRoles is AccessControlUpgradeable, MixinErrors {
return hasRole(LOCK_MANAGER_ROLE, account);
}

function addLockManager(address account) public {
_onlyLockManager();
grantRole(LOCK_MANAGER_ROLE, account);
emit LockManagerAdded(account);
}

function renounceLockManager() public {
renounceRole(LOCK_MANAGER_ROLE, msg.sender);
emit LockManagerRemoved(msg.sender);
}

uint256[1000] private __safe_upgrade_gap;
}
Loading