-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(smart-contracts): lower contract size for PublicLock v15 #14846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contract size audit here https://observablehq.com/d/fcfc7fa77ef2dd13 |
…ocol/unlock into lower-lock-contract-size-v15
…ocol/unlock into lower-lock-contract-size-v15
julien51
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes some code from PublicLock template so more features can be added without hitting the EVM contract size limit
Size: before :
23.956
/ after:22.636
Make some function private (avoid storing/copying full signature)
schemaVersion
(-0.032)updateSchemaVersion
internal (?)Functions removed
addLockManager
(duplicate ofhasRole(LOCK_MANAGER_ROLE, address)
) andrenounceLockManager
(duplicate ofrenounceRole(LOCK_MANAGER_ROLE)
) (-0.220)isApprovedForAll
andsetApprovalForAll
(-0.477)hooks
getter (-0.061)Other cleanup
NOT doing:
group fees into a single getter and a single setter (gas refund, transfer fee, cancel fee)(+0.063)refactor hooks addresses getters into a single hooks getter(-0.061)Potential candidates for deletion
burn
lendKey
/unlendKey
,mergeKeys
Issues
Fixes #
Refs #
Checklist:
Release Note Draft Snippet