Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seventh reconciliation PR from production/RRFS.v1 #2530

Merged
merged 21 commits into from
Jan 3, 2025
Merged

Seventh reconciliation PR from production/RRFS.v1 #2530

merged 21 commits into from
Jan 3, 2025

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Dec 5, 2024 •
edited by jkbk2004
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This is work from @haiqinli and is identical to #2343 except it targets the develop branch.

  • to compile the model with new fms/2024.01

  • Update the RUC LSM deep soil temperature from climatology to real forecast.

Commit Message:

* UFSWM - to compile the model with new fms/2024.01; Update the RUC LSM deep soil temperature from climatology to real forecast
  * FV3 - to compile the model with new fms/2024.01; Update the RUC LSM deep soil temperature from climatology to real forecast
    * ccpp-physics - Update the RUC LSM deep soil temperature from climatology to real forecast

Priority:

  • High: Needed for SRW App

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn (skip)
  • CI
  • opnReqTest (complete task if unnecessary)

@grantfirl grantfirl marked this pull request as ready for review December 19, 2024 19:46
@grantfirl
Copy link
Collaborator Author

The full RTs are running on Hera and are almost finished. Tests that use the RUC LSM are expected to change baseline results. I'll upload the logs when the tests complete.

@grantfirl
Copy link
Collaborator Author

The changed baseline results are as expected given the code changes.

@jkbk2004
Copy link
Collaborator

@grantfirl as #2529 has an issue, we like to move on working on this pr. Sorry about my last commit to the branch: I was confused. I think I fixed ok. Can you sync up branches? So we can go ahead for testing.

@grantfirl
Copy link
Collaborator Author

@grantfirl as #2529 has an issue, we like to move on working on this pr. Sorry about my last commit to the branch: I was confused. I think I fixed ok. Can you sync up branches? So we can go ahead for testing.

@jkbk2004 OK, should be good to test now. Everything is synced up.

@jkbk2004 jkbk2004 added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Dec 31, 2024
@BrianCurtis-NOAA
Copy link
Collaborator

Skip Acorn, still working through some permissions issues there.

@BrianCurtis-NOAA
Copy link
Collaborator

@jkbk2004 A couple questions: Are we running ORT's any more. Has the PR template been updated since we starting running both gaea c6 and gaea c5 RT's?

@jkbk2004 jkbk2004 added the jenkins-ort run ORT testing label Jan 2, 2025
@jkbk2004 jkbk2004 removed the jenkins-ort run ORT testing label Jan 3, 2025
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jan 3, 2025

We can start merging process.

@jkbk2004 jkbk2004 mentioned this pull request Jan 3, 2025
Merged
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Jan 3, 2025

@grantfirl new FV3 hash is NOAA-EMC/fv3atm@0834c7b

@jkbk2004 jkbk2004 merged commit 76471dc into ufs-community:develop Jan 3, 2025
4 checks passed
@JessicaMeixner-NOAA JessicaMeixner-NOAA mentioned this pull request Jan 6, 2025
Merged
21 tasks
WalterKolczynski-NOAA added a commit to NOAA-EMC/global-workflow that referenced this pull request Jan 17, 2025
@JessicaMeixner-NOAA @aerorahul
@sbanihash @DavidHuber-NOAA @WalterKolczynski-NOAA
Make assorted updates to waves (#3190)
57ce1b0 
This PR adds the following: 
* converting from inp -> nml (@sbanihash) 
* turning on PIO for waves for restarts (@sbanihash) 
* enabling cycling for WW3 which required some updates to wave prep jobs
+ changing what restarts are being saved/etc
* changed the way CEMPS, MOM6, CICE and WW3 write restarts to be in sync
with FV3 for IAU, which required moving the ufs-weather-model forward
one hash to use the new flexible restart feature. (UFS PR
ufs-community/ufs-weather-model#2419)
* adds uglo_15km - the targeted new wave grid. 
* Update to use new esmf_threading ufs.configure files which changes the
toggle between how you use esmf threading versus traditional threading
(UFS PR ufs-community/ufs-weather-model#2538)

Notes on ufs-weather-model updates: 
| Commit date | Commit hash/ PR | Notes for g-w changes | Baseline
Changes |
| :------------- | :------------- | :------------- | :------------- |
| Dec 11, 2024 |
ufs-community/ufs-weather-model@409bc85
ufs-community/ufs-weather-model#2419 | Enables
flexible restart writes - changes included in g-w PR | none|
| Dec 16, 2024 |
ufs-community/ufs-weather-model@6ec6b45
ufs-community/ufs-weather-model#2528
ufs-community/ufs-weather-model#2469 | n/a |
HAFs test changes, no global changes |
| Dec 18, 2024
|ufs-community/ufs-weather-model@e119370
ufs-community/ufs-weather-model#2448 | Adds Gaea
C6 support (changes in other g-w PRs, not here) | none |
|Dec 23, 2024 |
ufs-community/ufs-weather-model@2950089
ufs-community/ufs-weather-model#2533
ufs-community/ufs-weather-model#2538 | changes
for ESMF vs traditional threading | none |
|Dec 30, 2024 |
ufs-community/ufs-weather-model@241dd8e
ufs-community/ufs-weather-model#2485 | n/a |
changes in conus13km, no global changes|
|Jan 3, 2025 |
ufs-community/ufs-weather-model@76471dc
ufs-community/ufs-weather-model#2530 | n/a |
changes in regional tests, no global changes |

Note this PR requires the following: 
* update to fix files to add uglo_15km 
* staging ICs for high resolution test case for uglo_15km 

Co-author: @sbanihash 

Related Issues: 
- Fixes #1457 
- Fixes #3154
- Fixes #1795 
- related to #1776 

---------

Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Saeideh Banihashemi <[email protected]>
Co-authored-by: David Huber <[email protected]>
Co-authored-by: Walter Kolczynski - NOAA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@dpsarmie dpsarmie Awaiting requested review from dpsarmie

@FernandoAndrade-NOAA FernandoAndrade-NOAA Awaiting requested review from FernandoAndrade-NOAA

@NickSzapiro-NOAA NickSzapiro-NOAA Awaiting requested review from NickSzapiro-NOAA

Assignees
No one assigned
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grantfirl @jkbk2004 @BrianCurtis-NOAA @FernandoAndrade-NOAA