-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make assorted updates to waves #3190
Make assorted updates to waves #3190
Conversation
Conflicts: .gitmodules
…reading if desired
…combineforww3testing
I just merged in the latest change from develop - i'm not sure if that'll take care of the issues here or not. |
I wouldn't expect it to. |
Okay - this PR: ufs-community/ufs-weather-model#2533 added a new variable histaux_enabled which is only in s2s not in s2sw which is why this wasn't seen already. Should have a fix here shortly. |
@WalterKolczynski-NOAA - cannot confirm the fix yet, but I suspect i've pushed the fix now. |
@WalterKolczynski-NOAA - My test has gotten past the previous failure: /work2/noaa/marine/jmeixner/hercules/PR3190wcdatest/wcda1/COMROOT/wcda1/logs/2021032418/gdas_fcst_seg0.log |
CI Passed on Hera in Build# 4
|
CI Passed on Hercules in Build# 5
|
57ce1b0
into
NOAA-EMC:develop
Description
This PR adds the following:
Notes on ufs-weather-model updates:
Note this PR requires the following:
Co-author: @sbanihash
Related Issues:
Type of change
Change characteristics
How has this been tested?
Tests were done by adding waves to C48mx500 3DVar tests for cycling.
High resolution tests cases were also added.
This likely needs a new round of testing before CI and after staged ICs & new fix files are added.
Checklist