Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assorted updates to waves #3190

Conversation

JessicaMeixner-NOAA
Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Dec 20, 2024

Description

This PR adds the following:

Notes on ufs-weather-model updates:

Commit date Commit hash/ PR Notes for g-w changes Baseline Changes
Dec 11, 2024 ufs-community/ufs-weather-model@409bc85 ufs-community/ufs-weather-model#2419 Enables flexible restart writes - changes included in g-w PR none
Dec 16, 2024 ufs-community/ufs-weather-model@6ec6b45 ufs-community/ufs-weather-model#2528 ufs-community/ufs-weather-model#2469 n/a HAFs test changes, no global changes
Dec 18, 2024 ufs-community/ufs-weather-model@e119370 ufs-community/ufs-weather-model#2448 Adds Gaea C6 support (changes in other g-w PRs, not here) none
Dec 23, 2024 ufs-community/ufs-weather-model@2950089 ufs-community/ufs-weather-model#2533 ufs-community/ufs-weather-model#2538 changes for ESMF vs traditional threading none
Dec 30, 2024 ufs-community/ufs-weather-model@241dd8e ufs-community/ufs-weather-model#2485 n/a changes in conus13km, no global changes
Jan 3, 2025 ufs-community/ufs-weather-model@76471dc ufs-community/ufs-weather-model#2530 n/a changes in regional tests, no global changes

Note this PR requires the following:

  • update to fix files to add uglo_15km
  • staging ICs for high resolution test case for uglo_15km

Co-author: @sbanihash

Related Issues:

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)

Change characteristics

How has this been tested?

Tests were done by adding waves to C48mx500 3DVar tests for cycling.
High resolution tests cases were also added.

This likely needs a new round of testing before CI and after staged ICs & new fix files are added.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

JessicaMeixner-NOAA and others added 30 commits July 15, 2024 16:55
@JessicaMeixner-NOAA
Copy link
Contributor Author

I just merged in the latest change from develop - i'm not sure if that'll take care of the issues here or not.

@WalterKolczynski-NOAA
Copy link
Contributor

I just merged in the latest change from develop - i'm not sure if that'll take care of the issues here or not.

I wouldn't expect it to.

@JessicaMeixner-NOAA
Copy link
Contributor Author

Okay - this PR: ufs-community/ufs-weather-model#2533 added a new variable histaux_enabled which is only in s2s not in s2sw which is why this wasn't seen already. Should have a fix here shortly.

@JessicaMeixner-NOAA
Copy link
Contributor Author

I just merged in the latest change from develop - i'm not sure if that'll take care of the issues here or not.

I wouldn't expect it to.

@WalterKolczynski-NOAA - cannot confirm the fix yet, but I suspect i've pushed the fix now.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed CI-Hercules-Failed **Bot use only** CI testing on Hercules for this PR has failed labels Jan 16, 2025
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Jan 16, 2025
@JessicaMeixner-NOAA
Copy link
Contributor Author

@WalterKolczynski-NOAA - My test has gotten past the previous failure: /work2/noaa/marine/jmeixner/hercules/PR3190wcdatest/wcda1/COMROOT/wcda1/logs/2021032418/gdas_fcst_seg0.log

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jan 16, 2025
@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels Jan 17, 2025
@emcbot
Copy link

emcbot commented Jan 17, 2025

CI Passed on Hera in Build# 4
Built and ran in directory /scratch1/NCEPDEV/global/CI/3190


Experiment C96_S2SWA_gefs_replay_ics_8fde3150 Completed 1 Cycles: *SUCCESS* at Thu Jan 16 22:53:33 UTC 2025
Experiment C48mx500_3DVarAOWCDA_8fde3150 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 23:00:42 UTC 2025
Experiment C48_ATM_8fde3150 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 23:06:53 UTC 2025
Experiment C48mx500_hybAOWCDA_8fde3150 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 23:06:56 UTC 2025
Experiment C96C48_hybatmaerosnowDA_8fde3150 Completed 3 Cycles: *SUCCESS* at Fri Jan 17 00:20:43 UTC 2025
Experiment C96_atm3DVar_8fde3150 Completed 3 Cycles: *SUCCESS* at Fri Jan 17 00:27:05 UTC 2025
Experiment C96C48_hybatmDA_8fde3150 Completed 3 Cycles: *SUCCESS* at Fri Jan 17 00:27:36 UTC 2025
Experiment C48_S2SWA_gefs_8fde3150 Completed 1 Cycles: *SUCCESS* at Fri Jan 17 00:39:52 UTC 2025
Experiment C48_S2SW_8fde3150 Completed 2 Cycles: *SUCCESS* at Fri Jan 17 00:52:09 UTC 2025
Experiment C96C48_ufs_hybatmDA_8fde3150 Completed 3 Cycles: *SUCCESS* at Fri Jan 17 00:58:15 UTC 2025

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Jan 17, 2025
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Jan 17, 2025
@emcbot
Copy link

emcbot commented Jan 17, 2025

CI Passed on Hercules in Build# 5
Built and ran in directory /work2/noaa/global/CI/HERCULES/3190


Experiment C48_ATM_8fde3150 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 21:41:48 CST 2025
Experiment C48mx500_3DVarAOWCDA_8fde3150 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 21:47:49 CST 2025
Experiment C48mx500_hybAOWCDA_8fde3150 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 22:00:00 CST 2025
Experiment C96_S2SWA_gefs_replay_ics_8fde3150 Completed 1 Cycles: *SUCCESS* at Thu Jan 16 22:06:11 CST 2025
Experiment C96_atm3DVar_8fde3150 Completed 3 Cycles: *SUCCESS* at Thu Jan 16 23:00:27 CST 2025
Experiment C48_S2SW_8fde3150 Completed 2 Cycles: *SUCCESS* at Thu Jan 16 23:00:30 CST 2025
Experiment C96C48_hybatmDA_8fde3150 Completed 3 Cycles: *SUCCESS* at Thu Jan 16 23:00:34 CST 2025
Experiment C48_S2SWA_gefs_8fde3150 Completed 1 Cycles: *SUCCESS* at Thu Jan 16 23:19:06 CST 2025

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title Various wave updates: Reformat WW3 inputs; enable PIO for wave restarts; enable WW3 cycling; synchronize UFS restart writes; add uglo_15km WW3 grid Make assorted updates to waves Jan 17, 2025
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 57ce1b0 into NOAA-EMC:develop Jan 17, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
8 participants