Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

feat: incentive for PullRequest reviewers #657

Merged
merged 25 commits into from
Sep 15, 2023
Merged

feat: incentive for PullRequest reviewers #657

merged 25 commits into from
Sep 15, 2023

Conversation

wannacfuture
Copy link
Contributor

@netlify
Copy link

netlify bot commented Aug 23, 2023 •
edited
Loading

✅ Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit 51fe4df
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/650392b5cda46400070d2be4
😎 Deploy Preview https://deploy-preview-657--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wannacfuture wannacfuture changed the title feat: incentiveForPullRequest reviewers feat: incentive for PullRequest reviewers Aug 23, 2023
0x4007
0x4007 reviewed Aug 23, 2023
View reviewed changes
src/handlers/payout/post.ts Outdated Show resolved Hide resolved
whilefoo
whilefoo suggested changes Aug 23, 2023
View reviewed changes
src/handlers/payout/post.ts Outdated Show resolved Hide resolved
src/handlers/payout/post.ts Outdated Show resolved Hide resolved
0xcodercrane
0xcodercrane suggested changes Aug 24, 2023
View reviewed changes
src/handlers/payout/post.ts Outdated Show resolved Hide resolved
src/handlers/payout/post.ts Outdated Show resolved Hide resolved
@0x4007 0x4007 mentioned this pull request Aug 24, 2023
Closed
@wannacfuture
Copy link
Contributor Author

wannacfuture commented Aug 24, 2023 •
edited
Loading

The only problem here is:

the issue has several linked PRs and we will not sure which pr has solved that issue.
I'm assuming the last one(merged one) will be the correct fixing pr.

RFC @pavlovcik , @0xcodercrane

whilefoo
whilefoo suggested changes Aug 24, 2023
View reviewed changes
src/helpers/parser.ts Outdated Show resolved Hide resolved
src/handlers/payout/post.ts Outdated Show resolved Hide resolved
@0x4007
Copy link
Member

0x4007 commented Aug 24, 2023

The only problem here is:

the issue has several linked PRs and we will not sure which pr has solve that issue. I'm assuming the last one(merged one) will be the correct fixing pr.

RFC @pavlovcik , @0xcodercrane

Okay so no double dipping on the conversation rewards. That makes sense.

@wannacfuture wannacfuture requested a review from whilefoo August 24, 2023 12:31
whilefoo
whilefoo suggested changes Aug 25, 2023
View reviewed changes
src/handlers/payout/post.ts Outdated Show resolved Hide resolved
src/handlers/payout/post.ts Outdated Show resolved Hide resolved
src/handlers/payout/post.ts Outdated Show resolved Hide resolved
@wannacfuture wannacfuture requested a review from whilefoo August 25, 2023 15:30
whilefoo
whilefoo suggested changes Aug 26, 2023
View reviewed changes
src/helpers/parser.ts Outdated Show resolved Hide resolved
0x4007
0x4007 reviewed Aug 29, 2023
View reviewed changes
src/helpers/parser.ts Outdated Show resolved Hide resolved
@wannacfuture wannacfuture mentioned this pull request Aug 30, 2023
Open
@wannacfuture
Copy link
Contributor Author

@whilefoo , @pavlovcik Reminder here

@0x4007
Copy link
Member

0x4007 commented Sep 5, 2023

I can't handle reviews this week because I'm pretty much strictly mobile at the conference. I asked @rndquu to fill in for me though.

whilefoo
whilefoo suggested changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the getPullRequestReviews only retrieves reviews but not its comments, for that review comments api is needed.

src/helpers/parser.ts Show resolved Hide resolved
src/helpers/parser.ts Outdated Show resolved Hide resolved
src/helpers/parser.ts Outdated Show resolved Hide resolved
src/helpers/parser.ts Show resolved Hide resolved
src/helpers/parser.ts Outdated Show resolved Hide resolved
src/helpers/parser.ts Outdated Show resolved Hide resolved
src/helpers/parser.ts Outdated Show resolved Hide resolved
src/helpers/parser.ts Outdated Show resolved Hide resolved
@rndquu rndquu marked this pull request as draft September 6, 2023 14:56
@wannacfuture wannacfuture mentioned this pull request Sep 12, 2023
Merged
@wannacfuture wannacfuture marked this pull request as ready for review September 12, 2023 02:51
@wannacfuture
Copy link
Contributor Author

@rndquu , @whilefoo Reminder here

@wannacfuture wannacfuture mentioned this pull request Sep 13, 2023
Open
@0x4007 0x4007 mentioned this pull request Sep 13, 2023
Open
3 tasks
@0xcodercrane
Copy link
Contributor

0xcodercrane commented Sep 14, 2023 •
edited
Loading

@rndquu , @whilefoo Reminder here

If no critical change requests, I am gonna merge the PR in 1 hr

@0xcodercrane 0xcodercrane mentioned this pull request Sep 14, 2023
Merged
@0x4007 0x4007 enabled auto-merge September 14, 2023 21:30
@0x4007
Copy link
Member

0x4007 commented Sep 14, 2023

I think @whilefoo needs to approve

@0x4007 0x4007 merged commit 0154b7e into ubiquity:development Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@web4er web4er web4er left review comments

@whilefoo whilefoo whilefoo approved these changes

@0xcodercrane 0xcodercrane 0xcodercrane approved these changes

@0x4007 0x4007 Awaiting requested review from 0x4007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contributor Comment Financial Incentives - On Pull Request
5 participants
@wannacfuture @0x4007 @0xcodercrane @web4er @whilefoo