-
Notifications
You must be signed in to change notification settings - Fork 61
Automatic Stack Traces for Logger
#665
Comments
/start |
Tips:
|
Hello @pavlovcik , Could you please provide some more context and share the GitHub file links? Thank you. |
/unassign |
/stop |
You have been unassigned from the bounty @Sadaf-A |
/start |
Tips:
|
Refactor the log function so that redundant prefixes passing in are removed. Those should be automatically derived from the stack trace. The prefixes can be optionally enabled for any log function. Resolves: ubiquity#665
Refactor the log function so that redundant prefixes passing in are removed. Those should be automatically derived from the stack trace. The prefixes can be optionally enabled for any log function. Resolves: ubiquity#665
Refactor the log function so that redundant prefixes passing in are removed. Those should be automatically derived from the stack trace. The prefixes can be optionally enabled for any log function. Resolves: ubiquity#665
I had a look at Logger interface type
and used options JSON object to introduce a new optional 'logFnName' option. Now any |
Update: I see that linter on CI complains about no-prototype-builtins , I will try to workaround that. |
Problem solved, build is passing now. PR ready for the review. |
Do you have any updates @gitcoindev? If you would like to release the bounty back to the DevPool, please comment |
A message for the bot: as discussed during Pr review, the feature will be part of a big refactoring and credit will be given afterwards. |
These linked pull requests are closed: #873 |
Do you have any updates @gitcoindev? If you would like to release the bounty back to the DevPool, please comment |
Bot: will be credited after merging #644 |
Do you have any updates @gitcoindev? If you would like to release the bounty back to the DevPool, please comment |
Bot: will be credited after merging #644 |
You don't need to worry about the follow ups if they are tedious. Nobody can self assign and take over a task on this repository. Just be sure to remind me of all the tasks you are owed for once this is ready again. Also I realized that I handled this in my refactor lol but you can still get credit. |
Do you have any updates @gitcoindev? If you would like to release the bounty back to the DevPool, please comment |
@gitcoindev - Releasing the bounty back to dev pool because the allocated duration already ended! |
+ Evaluating results. Please wait... |
@pavlovcik the deadline is at 2024-02-17T12:35:01.070Z |
We should refactor the log function so that we dont have redundant prefixes we are passing in. Those should be automatically derived from the stack trace.
I believe this will require us to use traditional function declarations, not anonymous functions, in order to access the function names for the stack traces. This simplifies debugging.
#657 (comment)
Originally posted by @pavlovcik in #657 (comment)
The text was updated successfully, but these errors were encountered: