Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added skipBotEvents options in the manifest.ts type #54

Closed
wants to merge 1 commit into from
Closed

fix: added skipBotEvents options in the manifest.ts type #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/types/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export const manifestSchema = T.Object({
description: T.Optional(T.String({ default: "" })),
commands: T.Optional(T.Record(T.String({ pattern: "^[A-Za-z-_]+$" }), commandSchema, { default: {} })),
"ubiquity:listeners": T.Optional(T.Array(runEvent, { default: [] })),
"ubiquity:skipBotEvents": T.Optional(T.Boolean({ default: true })),
configuration: T.Optional(T.Record(T.String(), T.Any(), { default: {} })),
skipBotEvents: T.Optional(T.Boolean({ default: true })),
Comment on lines +17 to 19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipBotEvents is already present. I'm not even sure what's the benefit of following the manifest standard so strictly, then configuration should also be ubiquity:configuration since it's not in the standard.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice it thanks for pointing it out. It was to stick to our format but I do agree that I do not see much benefit either, we are not running a web extension. Will close this, all the other pull-requests with the updated manifest are open.

});
Expand Down
Loading