fix: added skipBotEvents options in the manifest.ts type #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whilefoo
reviewed
Jan 20, 2025
Comment on lines
+17
to
19
| "ubiquity:skipBotEvents": T.Optional(T.Boolean({ default: true })), | ||
| configuration: T.Optional(T.Record(T.String(), T.Any(), { default: {} })), | ||
| skipBotEvents: T.Optional(T.Boolean({ default: true })), |
There was a problem hiding this comment.
skipBotEvents is already present. I'm not even sure what's the benefit of following the manifest standard so strictly, then configuration should also be ubiquity:configuration since it's not in the standard.
There was a problem hiding this comment.
I didn't notice it thanks for pointing it out. It was to stick to our format but I do agree that I do not see much benefit either, we are not running a web extension. Will close this, all the other pull-requests with the updated manifest are open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ubiquity-os/ubiquity-os-kernel#232