Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: add Japanese translation #14502

Merged
merged 14 commits into from
Jan 14, 2025
Merged

diff: add Japanese translation #14502

merged 14 commits into from
Jan 14, 2025

Conversation

luna029
Copy link
Contributor

@luna029 luna029 commented Oct 31, 2024

Translated into Japanese.

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

Translated into Japanese.
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the translation Issues requesting translating pages from English to other languages. label Oct 31, 2024
@spageektti spageektti changed the title Create diff.md diff: add Japanese translation Oct 31, 2024
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please translate old_file and new_file as well.

pages.ja/common/diff.md Outdated Show resolved Hide resolved
pages.ja/common/diff.md Outdated Show resolved Hide resolved
pages.ja/common/diff.md Show resolved Hide resolved
pages.ja/common/diff.md Outdated Show resolved Hide resolved
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages.ja/common/diff.md:14: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

Co-authored-by: Sebastiaan Speck <[email protected]>
@Managor
Copy link
Collaborator

Managor commented Dec 20, 2024

Is the bot complaining because the "More information" translation doesn't match what is in more-info-link.md?
more-info-link.md: 詳しくはこちら:
diff.md: 詳細はこちら:

@sebastiaanspeck sebastiaanspeck added the waiting Issues/PRs with Pending response by the author. label Dec 30, 2024
@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Dec 30, 2024
@sebastiaanspeck
Copy link
Member

Is the bot complaining because the "More information" translation doesn't match what is in more-info-link.md?

more-info-link.md: 詳しくはこちら:

diff.md: 詳細はこちら:

You can run scripts/set-more-info-link.py -S -l ja to fix it automatically.

@sebastiaanspeck sebastiaanspeck added the waiting Issues/PRs with Pending response by the author. label Dec 30, 2024
@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Dec 30, 2024
@Managor
Copy link
Collaborator

Managor commented Dec 30, 2024

Since I don't speak japanese, I have to ask: Which writing form is more correct? There must be a reason why @luna029 used kanji here.

@sebastiaanspeck
Copy link
Member

Since I don't speak japanese, I have to ask: Which writing form is more correct? There must be a reason why @luna029 used kanji here.

I would also like tot ask why it does not end with a period or .

@github-actions github-actions bot added new translation PRs translating a page(s) from English to other languages. review needed Prioritized PRs marked for reviews from maintainers. labels Jan 5, 2025
@sebastiaanspeck sebastiaanspeck added waiting Issues/PRs with Pending response by the author. and removed translation Issues requesting translating pages from English to other languages. labels Jan 5, 2025
Co-authored-by: Sebastiaan Speck <[email protected]>
@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Jan 12, 2025
@Managor
Copy link
Collaborator

Managor commented Jan 13, 2025

I have it another confirmation that this might be a machine translation.

both are OK, but the OP's translation is obviously non-native to begin with. mixing する and です/ます is a common machine translation mistake (picking either is OK but one must stay consistent with the style)

Also about "More information:"

I'd say もっと詳しく: might be more natural (こちら means here and it is more common to imply it instead of explicitly stating it)

@sebastiaanspeck
Copy link
Member

I have it another confirmation that this might be a machine translation.

both are OK, but the OP's translation is obviously non-native to begin with. mixing する and です/ます is a common machine translation mistake (picking either is OK but one must stay consistent with the style)

Also about "More information:"

I'd say もっと詳しく: might be more natural (こちら means here and it is more common to imply it instead of explicitly stating it)

Feel free to open a PR to address this.

@Managor
Copy link
Collaborator

Managor commented Jan 13, 2025

Done #15502

@Managor
Copy link
Collaborator

Managor commented Jan 13, 2025

That tldr-bot error message is misleading and should be fixed. It's not that it's not matching with the english page, but that it's not matching with the traslated page in more-info-link.md

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@Managor Managor merged commit fe05e8b into tldr-pages:main Jan 14, 2025
3 checks passed
@sebastiaanspeck
Copy link
Member

That tldr-bot error message is misleading and should be fixed. It's not that it's not matching with the english page, but that it's not matching with the traslated page in more-info-link.md

Feel free to open a PR to clarify the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new translation PRs translating a page(s) from English to other languages. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants