Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent chrome default autocomplete colors #2247

Closed
wants to merge 1 commit into from

Conversation

felix-ico
Copy link
Collaborator

should fix
#2081
and
#2245

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit d5e4efb
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/6596bfe1e0a3b50008a2439f
😎 Deploy Preview https://deploy-preview-2247--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -302,7 +302,8 @@ input:-webkit-autofill,
input:-webkit-autofill:hover,
input:-webkit-autofill:focus,
input:-webkit-autofill:active {
color-scheme: dark;
/* hack to remove autocomplete colors in chrome, as they conflict with scale dark/light mode styles https://stackoverflow.com/a/68240841 */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super happy about this haha… do you think we could try testing with adding color-scheme: light dark; globally in :root (in the global CSS file) and remove this color-scheme rules for the Text Field only?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey I did test that already in the old PR for this same issue #2191 (comment) , but just adding color-scheme: light dark; to the global css does not fix the issue as far as i can see... (these changes would still be needed for it to work https://github.com/telekom/scale/pull/2191/files)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean, it seems like just adding color-scheme: light dark; by itself would not fix the issue

@felix-ico felix-ico closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants