Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autocomplete colors #2191

Closed
wants to merge 2 commits into from
Closed

fix: autocomplete colors #2191

wants to merge 2 commits into from

Conversation

felix-ico
Copy link
Collaborator

fixes #2081

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit ce95266
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/6544ea76f4eddc000858e48f
😎 Deploy Preview https://deploy-preview-2191--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +305 to +307
-webkit-box-shadow: 0 0 0px 100px
var(--telekom-color-text-and-icon-inverted-additional) inset !important;
-webkit-text-fill-color: var(--color-meta);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a cleaner way to fix this would be make the value of color-scheme be light dark so it handles both modes, correctly. I tested this locally. I got this from here: https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme#adapting_to_color_schemes

Even better, we could remove this input:-webkit-autofill bit completely, and add the color-scheme: light dark; rule in the :root of either the scale.css or even the design tokens CSS file… whatcha think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I added it in the body for convenience.

Screenshot 2023-11-07 at 13 36 57 Screenshot 2023-11-07 at 13 37 04

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess we should add this. If i remove the -webkit-autofill part and just set data-mode="dark" the autofill still looks broken though

Screenshot 2023-11-07 at 14 19 27

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct… the idea is to remove the -webkit-autofill rules from Text Field, and add

:root {
  color-scheme: light dark;
}

to either scale.css or the design-tokens.all.css output.

@felix-ico
Copy link
Collaborator Author

closing this in favor of #2247 (seems like a more flexible solution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autocomplete scale-text-field in dark mode
2 participants