-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: autocomplete colors #2191
fix: autocomplete colors #2191
Conversation
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
-webkit-box-shadow: 0 0 0px 100px | ||
var(--telekom-color-text-and-icon-inverted-additional) inset !important; | ||
-webkit-text-fill-color: var(--color-meta); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a cleaner way to fix this would be make the value of color-scheme
be light dark
so it handles both modes, correctly. I tested this locally. I got this from here: https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme#adapting_to_color_schemes
Even better, we could remove this input:-webkit-autofill
bit completely, and add the color-scheme: light dark;
rule in the :root of either the scale.css or even the design tokens CSS file… whatcha think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct… the idea is to remove the -webkit-autofill rules from Text Field, and add
:root {
color-scheme: light dark;
}
to either scale.css
or the design-tokens.all.css
output.
closing this in favor of #2247 (seems like a more flexible solution) |
fixes #2081