Adds configuration for local file system connector. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Local File System volume configuration with environment variable support.
avaz
changed the title
baranbartu
reviewed
Jul 22, 2024
| @@ -24,6 +24,9 @@ RAY_MEMORY=100G | |||
| FRONTEND_PROTOCOL=http | |||
| SECURED_COOKIES="False" | |||
|
|
|||
| # Path to the local host file system where the Local File System connector will write the data | |||
| SYNTHO_LOCALFS=/tmp/ | |||
There was a problem hiding this comment.
Can you also add this env in this .tpl file here? syntho-cli is using this .tpl when generating the real .env file when deploying. We actually have a PR checks to avoid this discrepancy but apparently we missed adding this check for docker compose, and added for helm charts only. We talked with @Younday and that PR check will be added soon for docker compose as well.
There was a problem hiding this comment.
It's maybe also a good thing to check whether we want to merge this in, I believe it was a temporary fix. I will however create another PR with a check in a pipeline to see if the keys in .env.tpl and example.env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Local File System volume configuration with environment variable support.