Refactor extraction pipeline.2 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redur
commented
Apr 3, 2024
redur
commented
Apr 3, 2024
|
Now single files work as well without the temporary directory. |
redur
force-pushed
the
feat/configure_pipeline_with_arguments
branch
from
9679ad8 to
672a894
Compare
redur
force-pushed
the
feat/configure_pipeline_with_arguments_refactored
branch
from
4b2e86b to
d03d0b8
Compare
redur
force-pushed
the
feat/configure_pipeline_with_arguments_refactored
branch
from
d03d0b8 to
2166ad1
Compare
stijnvermeeren-swisstopo
requested changes
Apr 5, 2024
|
Thank you. Comments are addressed. |
stijnvermeeren-swisstopo
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here the discussed proposition.
I think we can extend the thought even further and include the draw_predictions earlier. That would require that we load the ground truth earlier as well. I keep this for the future as the current implementation currently already serves for discussion.