Feat/configure pipeline with arguments #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijnvermeeren-swisstopo
requested changes
Apr 3, 2024
There was a problem hiding this comment.
A few ideas/comments.
Also check the additional proposal/comments in #22
…run pipeline on individual files.
redur
force-pushed
the
feat/configure_pipeline_with_arguments
branch
from
9679ad8 to
672a894
Compare
stijnvermeeren-swisstopo
requested changes
Apr 5, 2024
There was a problem hiding this comment.
Looks good (on condition that #23 is approved and merged as well) apart from these minor details.
…guments_refactored Refactor extraction pipeline.2
…tory or a pdf path.
stijnvermeeren-swisstopo
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a CLI interface to run our main script.
We now have the option to define input and output directories.
We can specify single files for the pipeline to be run on.
We can specify what drawings are performed (bounding boxes for predictions and lines).