[release-2.9] 🤖 Sync from open-cluster-management-io/governance-policy-propagator: #127 #460
Conversation
The new `IsForPolicyOrPolicySet` may be very slightly faster than the previous implementation. The `GetPoliciesInPlacementBinding` function is from duplicated code. The removal of a `DeepCopy()` call may improve performance. Signed-off-by: Justin Kulikauskas <[email protected]> (cherry picked from commit fdc3118)
Previously, the `common` package had separate functions to get the decisions from a PlacementBinding depending on whether it was bound to a Placement or a PlacementRule. But every caller would need to use both, so that was unnecessary. Now, there is a unified `GetDecisions` func. Similarly, the `propagator` had separate functions to find the policy placements (not to be confused with Placements...), and the de- duplicated logic was brought to the `getPolicyPlacementDecisions` func more directly. Signed-off-by: Justin Kulikauskas <[email protected]> (cherry picked from commit 4178f22)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
SonarCloud Quality Gate failed.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
| } | ||
| result = append(result, common.GetPoliciesInPlacementBinding(ctx, c, &pb)...) |
Check warning
Code scanning / SonarCloud
Implicit memory aliasing in for loop. See more on SonarCloud Warning
| continue | ||
| } | ||
|
|
||
| plcDecisions, plcPlacements, err := r.getPolicyPlacementDecisions(instance, pb) | ||
| plcDecisions, plcPlacements, err := r.getPolicyPlacementDecisions(instance, &pb) |
Check warning
Code scanning / SonarCloud
Implicit memory aliasing in for loop. See more on SonarCloud Warning
| foundInDecisions := false | ||
|
|
||
| plcDecisions, plcPlacements, err := r.getPolicyPlacementDecisions(instance, pb) | ||
| plcDecisions, plcPlacements, err := r.getPolicyPlacementDecisions(instance, &pb) |
Check warning
Code scanning / SonarCloud
Implicit memory aliasing in for loop. See more on SonarCloud Warning
| } | ||
|
|
||
| result = append(result, common.GetPoliciesInPlacementBinding(ctx, c, &pb)...) |
Check warning
Code scanning / SonarCloud
Implicit memory aliasing in for loop. See more on SonarCloud Warning
|
/override "SonarCloud Code Analysis" |
|
@JustinKuli: Overrode contexts on behalf of JustinKuli: SonarCloud Code Analysis In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
merged commit 8e083fd
into
stolostron:release-2.9
This is an automated cherry-pick of #435
/assign JustinKuli