🤖 Sync from open-cluster-management-io/governance-policy-propagator: #127 #435
Conversation
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
The new `IsForPolicyOrPolicySet` may be very slightly faster than the previous implementation. The `GetPoliciesInPlacementBinding` function is from duplicated code. The removal of a `DeepCopy()` call may improve performance. Signed-off-by: Justin Kulikauskas <[email protected]> (cherry picked from commit fdc3118)
Previously, the `common` package had separate functions to get the decisions from a PlacementBinding depending on whether it was bound to a Placement or a PlacementRule. But every caller would need to use both, so that was unnecessary. Now, there is a unified `GetDecisions` func. Similarly, the `propagator` had separate functions to find the policy placements (not to be confused with Placements...), and the de- duplicated logic was brought to the `getPolicyPlacementDecisions` func more directly. Signed-off-by: Justin Kulikauskas <[email protected]> (cherry picked from commit 4178f22)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: magic-mirror-bot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
SonarCloud Quality Gate failed.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
| } | ||
| result = append(result, common.GetPoliciesInPlacementBinding(ctx, c, &pb)...) |
Check warning
Code scanning / SonarCloud
<!--SONAR_ISSUE_KEY:AYqPSsPE3PkE-TAvSFWh-->Implicit memory aliasing in for loop. <p>See more on <a href="https://sonarcloud.io/project/issues?id=open-cluster-management_governance-policy-propagator&issues=AYqPSsPE3PkE-TAvSFWh&open=AYqPSsPE3PkE-TAvSFWh&pullRequest=435">SonarCloud</a></p>
| foundInDecisions := false | ||
|
|
||
| plcDecisions, plcPlacements, err := r.getPolicyPlacementDecisions(instance, pb) | ||
| plcDecisions, plcPlacements, err := r.getPolicyPlacementDecisions(instance, &pb) |
Check warning
Code scanning / SonarCloud
<!--SONAR_ISSUE_KEY:AYqPSsTw3PkE-TAvSFWi-->Implicit memory aliasing in for loop. <p>See more on <a href="https://sonarcloud.io/project/issues?id=open-cluster-management_governance-policy-propagator&issues=AYqPSsTw3PkE-TAvSFWi&open=AYqPSsTw3PkE-TAvSFWi&pullRequest=435">SonarCloud</a></p>
| continue | ||
| } | ||
|
|
||
| plcDecisions, plcPlacements, err := r.getPolicyPlacementDecisions(instance, pb) | ||
| plcDecisions, plcPlacements, err := r.getPolicyPlacementDecisions(instance, &pb) |
Check warning
Code scanning / SonarCloud
<!--SONAR_ISSUE_KEY:AYqPSsTw3PkE-TAvSFWj-->Implicit memory aliasing in for loop. <p>See more on <a href="https://sonarcloud.io/project/issues?id=open-cluster-management_governance-policy-propagator&issues=AYqPSsTw3PkE-TAvSFWj&open=AYqPSsTw3PkE-TAvSFWj&pullRequest=435">SonarCloud</a></p>
| } | ||
|
|
||
| result = append(result, common.GetPoliciesInPlacementBinding(ctx, c, &pb)...) |
Check warning
Code scanning / SonarCloud
<!--SONAR_ISSUE_KEY:AYqPSsUU3PkE-TAvSFWk-->Implicit memory aliasing in for loop. <p>See more on <a href="https://sonarcloud.io/project/issues?id=open-cluster-management_governance-policy-propagator&issues=AYqPSsUU3PkE-TAvSFWk&open=AYqPSsUU3PkE-TAvSFWk&pullRequest=435">SonarCloud</a></p>
|
/cherry-pick release-2.9 |
|
@JustinKuli: new pull request created: #460 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Syncing the following PRs:
getPolicyPlacementDecisionsopen-cluster-management-io/governance-policy-propagator#127