Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bound and cache update checks #343

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

2opremio
Copy link
Contributor

No description provided.

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is up with event request validation, I think

cmd/stellar-rpc/internal/methods/get_events.go Outdated Show resolved Hide resolved
cmd/stellar-rpc/internal/db/cursor.go Show resolved Hide resolved
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a test failing so pls fix that first but otherwise this LGTM:

    get_events_test.go:436: 
        	Error Trace:	/home/runner/work/stellar-rpc/stellar-rpc/cmd/stellar-rpc/internal/methods/get_events_test.go:436
        	Error:      	Error message not equal:
        	            	expected: "startLedger must be positive"
        	            	actual  : "startLedger must be positive and <= than endLedger"
        	Test:       	TestGetEventsRequestValid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants