-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bound and cache update checks #343
Open
2opremio
wants to merge
8
commits into
stellar:main
Choose a base branch
from
2opremio:bound-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+37
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
bound-checks
branch
from
December 18, 2024 17:49
af7c2cf
to
1acc9af
Compare
tamirms
reviewed
Jan 9, 2025
tamirms
reviewed
Jan 9, 2025
Co-authored-by: tamirms <[email protected]>
Shaptic
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is up with event request validation, I think
Shaptic
reviewed
Jan 22, 2025
Shaptic
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a test failing so pls fix that first but otherwise this LGTM:
get_events_test.go:436:
Error Trace: /home/runner/work/stellar-rpc/stellar-rpc/cmd/stellar-rpc/internal/methods/get_events_test.go:436
Error: Error message not equal:
expected: "startLedger must be positive"
actual : "startLedger must be positive and <= than endLedger"
Test: TestGetEventsRequestValid
2opremio
force-pushed
the
bound-checks
branch
from
January 23, 2025 17:17
acd480f
to
6f75d1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.