Address review feedback

cmd/stellar-rpc/internal/methods/get_events.go

@@ -128,22 +128,21 @@ func (g *GetEventsRequest) Valid(maxLimit uint) error {
 		}
 	}
 
-	if g.Pagination != nil {
+	if g.Pagination != nil { //nolint:nestif
 		if g.Pagination.Cursor != nil && (g.StartLedger != 0 || g.EndLedger != 0) {
 			return errors.New("ledger ranges and cursor cannot both be set")
 		}
 		if g.Pagination.Limit > maxLimit {
 			return fmt.Errorf("limit must not exceed %d", maxLimit)
 		}
-		return nil
-	}
-
-	// Pagination not enabled
-	if g.StartLedger <= 0 {
-		return errors.New("startLedger must be positive")
-	}
-	if g.EndLedger > 0 && g.EndLedger < g.StartLedger {
-		return errors.New("startLedger must be <= endLedger")
+	} else {
+		// Pagination not enabled
+		if g.StartLedger <= 0 {
+			return errors.New("startLedger must be positive")
+		}
+		if g.EndLedger > 0 && g.EndLedger < g.StartLedger {
+			return errors.New("startLedger must be <= endLedger")
+		}
 	}
 
 	return nil

cmd/stellar-rpc/internal/methods/get_transactions.go

@@ -46,16 +46,14 @@ func (req GetTransactionsRequest) isValid(maxLimit uint, ledgerRange ledgerbucke
 		if req.Pagination.Limit > maxLimit {
 			return fmt.Errorf("limit must not exceed %d", maxLimit)
 		}
-		return nil
-	}
-	// Pagination is not enabled
-	if req.StartLedger < ledgerRange.FirstLedger.Sequence || req.StartLedger > ledgerRange.LastLedger.Sequence {
+	} else if req.StartLedger < ledgerRange.FirstLedger.Sequence || req.StartLedger > ledgerRange.LastLedger.Sequence {
 		return fmt.Errorf(
 			"start ledger must be between the oldest ledger: %d and the latest ledger: %d for this rpc instance",
 			ledgerRange.FirstLedger.Sequence,
 			ledgerRange.LastLedger.Sequence,
 		)
 	}
+
 	return nil
 }