Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more spectral extraction improvements for downstream use #3227

Merged
merged 4 commits into from
Jan 22, 2025
Merged

more spectral extraction improvements for downstream use #3227

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61f5b2e
only show function dropdown if multiple choices
kecnry Oct 17, 2024
2dd6ffc
improve styling of photutils docs link when plugin is wide
kecnry Oct 17, 2024
4883677
don't show warning if spectrum_y_units is not even defined
kecnry Oct 17, 2024
56c0e18
external photutils link on separate row
kecnry Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions jdaviz/configs/cubeviz/plugins/spectral_extraction/spectral_extraction.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,16 +209,17 @@
api_hint="plg.aperture_method ="
:api_hints_enabled="api_hints_enabled"
:hint="'Extract '+resulting_product_name+' using an aperture masking method in place of the subset mask.'"
>
/>
<v-row>
<j-docs-link>
See the <j-external-link link='https://photutils.readthedocs.io/en/stable/aperture.html#aperture-and-pixel-overlap'
linktext='photutils docs'></j-external-link>
for more details on aperture masking methods.
See the <j-external-link link='https://photutils.readthedocs.io/en/stable/aperture.html#aperture-and-pixel-overlap'
linktext='photutils docs'></j-external-link> for more details on aperture masking methods.
</j-docs-link>
</plugin-select>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, extra </plugin-select>? Is this a bug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, I replaced it above (line 212) with /> and moved the j-docs-link into its own row so that it looks better when the plugin is wide.

</v-row>
</div>

<plugin-select
v-if="function_items.length > 1"
:items="function_items.map(i => i.label)"
:selected.sync="function_selected"
label="Function"
Expand Down Expand Up @@ -258,7 +259,7 @@
@click:action="spectral_extraction"
>
<v-alert
v-if="results_units !== spectrum_y_units"
v-if="spectrum_y_units && results_units !== spectrum_y_units"
type='warning'
style="margin-left: -12px; margin-right: -12px"
>
Expand Down
Loading