-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more spectral extraction improvements for downstream use #3227
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3227 +/- ##
==========================================
- Coverage 87.60% 87.60% -0.01%
==========================================
Files 128 128
Lines 19856 19856
==========================================
- Hits 17395 17394 -1
- Misses 2461 2462 +1 ☔ View full report in Codecov by Sentry. |
* lcviz plans to restrict to only have sum as an option, so hide the dropdown in the UI
3430d1d
to
56c0e18
Compare
</j-docs-link> | ||
</plugin-select> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, extra </plugin-select>
? Is this a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, I replaced it above (line 212) with />
and moved the j-docs-link
into its own row so that it looks better when the plugin is wide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks uncontroversial enough. Thanks!
…s for downstream use
…am use (#3408) Co-authored-by: Kyle Conroy <[email protected]>
Description
This pull request implements several more generalizations/improvements so that spectral extraction can be inherited downstream (in lcviz in spacetelescope/lcviz#115 and possibly in rampviz in the future).
These are very minor changes - would it be unreasonable to consider this for the next bugfix release? Shouldn't affect jdaviz configs directly, so probably doesn't need a changelog?
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.