Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing dev tests with numpy 2.0 #1006

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Testing dev tests with numpy 2.0
hbrown-ST authored and zacharyburnett committed Jul 5, 2024
commit d966728b7e92e5ecbb41793c7867b5df51f2cefd
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
name = "crds"
description = "Calibration Reference Data System, HST/JWST/Roman reference file management"
authors = [{ name = "STScI CRDS s/w developers" }]
#requires-python = ">=3.11"
requires-python = ">=3.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
requires-python = ">=3.11"
requires-python = ">=3.9"

Since we support 3.9+

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment I can't get numpy 2.0 to be picked up without being in python 3.11.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are not even picking up numpy 2.0. The requirements file included in this PR does not appear to be doing anything.

Note that if you look at the dev wheels archive you are linking to in it. There very much are wheels for 3.9 and 3.10. Indeed this is true for both numpy and scipy.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right I found that numpy 2.0 wasn't getting picked up after some digging. Looking into that.

classifiers = [
"Intended Audience :: Science/Research",
"License :: OSI Approved :: BSD License",
4 changes: 2 additions & 2 deletions requirements-dev-numpy.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Use Bi-weekly numpy dev build
#--extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple
#numpy>=2.0.0.dev0
--extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple
numpy>=2.0.0.dev0