-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing dev tests with numpy 2.0 #1006
Draft
hbrown-ST
wants to merge
15
commits into
master
Choose a base branch
from
SCSB-90
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−1
Draft
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
661a0a6
Testing dev tests with numpy 2.0
hbrown-ST 69b0a01
Testing dev tests with numpy 2.0
hbrown-ST d966728
Testing dev tests with numpy 2.0
hbrown-ST f649143
Testing dev tests with numpy 2.0
hbrown-ST 9b1f184
Testing dev tests with numpy 2.0
hbrown-ST fd7cf3f
Testing dev tests with numpy 2.0
hbrown-ST dbce6fd
Continuing to try to test numpy 2.0
hbrown-ST 7d87e0e
Continuing to try to test numpy 2.0
hbrown-ST 133e2ad
Continuing to try to test numpy 2.0
hbrown-ST a994ab8
Continuing to try to test numpy 2.0
hbrown-ST 0b09c10
Continuing to try to test numpy 2.0
hbrown-ST 1a466af
Continuing to try to test numpy 2.0
hbrown-ST 1013dfa
Continuing to try to test numpy 2.0
hbrown-ST b3061c6
Continuing to try to test numpy 2.0
hbrown-ST 4687d2c
Continuing to try to test numpy 2.0
hbrown-ST File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Testing dev tests with numpy 2.0
commit d966728b7e92e5ecbb41793c7867b5df51f2cefd
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
# Use Bi-weekly numpy dev build | ||
#--extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple | ||
#numpy>=2.0.0.dev0 | ||
--extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple | ||
numpy>=2.0.0.dev0 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we support 3.9+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment I can't get numpy 2.0 to be picked up without being in python 3.11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are not even picking up
numpy 2.0
. The requirements file included in this PR does not appear to be doing anything.Note that if you look at the dev wheels archive you are linking to in it. There very much are wheels for 3.9 and 3.10. Indeed this is true for both numpy and scipy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right I found that numpy 2.0 wasn't getting picked up after some digging. Looking into that.