Testing dev tests with numpy 2.0 #1006
Draft
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyproject.toml
Outdated
| @@ -2,6 +2,7 @@ | |||
| name = "crds" | |||
| description = "Calibration Reference Data System, HST/JWST/Roman reference file management" | |||
| authors = [{ name = "STScI CRDS s/w developers" }] | |||
| requires-python = ">=3.11" | |||
There was a problem hiding this comment.
Suggested change
| requires-python = ">=3.11" | |
| requires-python = ">=3.9" |
Since we support 3.9+
There was a problem hiding this comment.
At the moment I can't get numpy 2.0 to be picked up without being in python 3.11.
There was a problem hiding this comment.
These tests are not even picking up numpy 2.0. The requirements file included in this PR does not appear to be doing anything.
Note that if you look at the dev wheels archive you are linking to in it. There very much are wheels for 3.9 and 3.10. Indeed this is true for both numpy and scipy.
There was a problem hiding this comment.
Right I found that numpy 2.0 wasn't getting picked up after some digging. Looking into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.