[chore] fix test expectations #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
fix_expectations
branch
from
0acda7e to
75a2405
Compare
atoulme
force-pushed
the
fix_expectations
branch
from
1d2607d to
cc733c2
Compare
Closed
dmitryax
approved these changes
Jan 10, 2025
jinja2
reviewed
Jan 10, 2025
| @@ -13,9 +13,6 @@ metadata: | |||
| release: {{ .Release.Name }} | |||
| heritage: {{ .Release.Service }} | |||
| app.kubernetes.io/component: otel-operator | |||
| annotations: | |||
There was a problem hiding this comment.
can we keep these in until we make the crd changes in the chart? it should still be okay to run this hook with the test install
There was a problem hiding this comment.
No, tests fail if we leave this hook. See https://github.com/signalfx/splunk-otel-collector-chart/actions/runs/12700626921/job/35403663872
There was a problem hiding this comment.
collector/templates/operator/instrumentation.yaml failed: 1 error occurred:
* Internal error occurred: failed calling webhook "minstrumentation.kb.io": failed to call webhook: Post "[https://sock-operator-webhook.default.svc:443/mutate-opentelemetry-io-v1alpha1-instrumentation?timeout=10s](https://sock-operator-webhook.default.svc/mutate-opentelemetry-io-v1alpha1-instrumentation?timeout=10s)": dial tcp 10.96.242.75:443: connect: connection refused
functional_test.go:300:
Error Trace: /home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/functional_test.go:300
/home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/functional_test.go:119
/opt/hostedtoolcache/go/1.22.10/x64/src/sync/once.go:74
/opt/hostedtoolcache/go/1.22.10/x64/src/sync/once.go:65
/home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/functional_test.go:98
/home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/functional_test.go:581
Error: Received unexpected error:
post-upgrade hooks failed: warning: Hook post-upgrade splunk-otel-collector/templates/operator/instrumentation.yaml failed: 1 error occurred:
* Internal error occurred: failed calling webhook "minstrumentation.kb.io": failed to call webhook: Post "[https://sock-operator-webhook.default.svc:443/mutate-opentelemetry-io-v1alpha1-instrumentation?timeout=10s](https://sock-operator-webhook.default.svc/mutate-opentelemetry-io-v1alpha1-instrumentation?timeout=10s)": dial tcp 10.96.242.75:443: connect: connection refused
```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix expectations - functional tests were not running and fell behind on expectations from testing.