Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #1596

Closed
wants to merge 3 commits into from
Closed

Fix tests #1596

wants to merge 3 commits into from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 9, 2025

No description provided.

@atoulme atoulme marked this pull request as ready for review January 9, 2025 15:14
@atoulme atoulme requested review from a team as code owners January 9, 2025 15:14
@hughesjj
Copy link
Contributor

hughesjj commented Jan 9, 2025

Looks good save for


splunk-otel-collector/crds/opentelemetry.io_opentelemetrycollectors.yaml
    functional_test.go:204: error reported during helm install: Kubernetes cluster unreachable: the server has asked for the client to provide credentials
    functional_test.go:209: 
        	Error Trace:	/home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/functional_test.go:209
        	            				/home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/functional_test.go:119
        	            				/home/runner/go/pkg/mod/golang.org/[email protected]/src/sync/once.go:74
        	            				/home/runner/go/pkg/mod/golang.org/[email protected]/src/sync/once.go:65
        	            				/home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/functional_test.go:98
        	            				/home/runner/work/splunk-otel-collector-chart/splunk-otel-collector-chart/functional_tests/functional_test.go:532
        	Error:      	Received unexpected error:
        	            	the server has asked for the client to provide credentials

@atoulme atoulme marked this pull request as draft January 10, 2025 00:37
@atoulme
Copy link
Contributor Author

atoulme commented Jan 10, 2025

I am breaking this change into multiple PRs, see #1601

@atoulme atoulme closed this Jan 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hughesjj hughesjj hughesjj approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atoulme @hughesjj