Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section about using Custom Events: GA4 Web #5377

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

sarahrudy
Copy link
Contributor

@sarahrudy sarahrudy commented Sep 19, 2023

Proposed changes

  • Add excerpt from Google's docs on when to use custom event
  • Add {:target='_blank'} to open new browser window when customers click on the link
  • Changed name of subsection from "Custom Event Naming" to be "Custom Events" instead
  • Added a couple words in front of the existing paragraph since I removed "Naming" from the subsection heading

Merge timing

  • ASAP once approved

- Add excerpt from Google's docs on when to use custom event 
- Add {:target='_blank'} to open new browser window when customers click on the link
@sarahrudy sarahrudy added the KCS label Sep 19, 2023
@sarahrudy sarahrudy marked this pull request as ready for review September 26, 2023 16:32
@sarahrudy sarahrudy requested a review from a team as a code owner September 26, 2023 16:32
@sarahrudy sarahrudy requested review from forstisabella and removed request for a team September 26, 2023 16:32
@forstisabella
Copy link
Contributor

forstisabella commented Oct 3, 2023

Hi @sarahrudy - I saw that there were a few changes present on this branch before you merged develop into this branch. Did you mean to remove those changes?

@sarahrudy
Copy link
Contributor Author

Hi @forstisabella - yes! I removed those changes intentionally. It reads as it should now, I believe.

@forstisabella forstisabella merged commit 14153e2 into develop Oct 9, 2023
@forstisabella forstisabella deleted the sarahrudy-patch-6 branch October 9, 2023 21:14
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants