[DO NOT MERGE] Update dependency for testing: deps/haskell-backend_release #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scott-Guest
force-pushed
the
krypto-bytes
branch
from
adda78b to
3fe1ea8
Compare
Scott-Guest
force-pushed
the
krypto-bytes
branch
from
3fe1ea8 to
55c8900
Compare
Scott-Guest
force-pushed
the
krypto-bytes
branch
from
506b122 to
721255c
Compare
rv-jenkins
pushed a commit
to runtimeverification/haskell-backend
that referenced
this pull request
Jan 9, 2024
Fixes #3683 The `KRYPTO` hooks now use `Bytes` for raw strings instead of `String`, so this PR updates the evaluators here accordingly. Additionally, I updated all tests that reference `KRYPTO` lest they give errors about hooked symbols having incorrect sorts. Specifically, - I regenerated the `regression-evm` tests by running `generate-regression-tests.sh` with my branch of KEVM that uses the updated hooks. - For all the tests that I couldn't regenerate, I manually patched them by changing the existing `KRYPTO` symbols into functions which wrap the new hooks with appropriate calls to `String2Bytes` and `Bytes2String`. Corresponding PR testing this on the booster: runtimeverification/hs-backend-booster#370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only exists to test that the corresponding changes on the haskell-backend (runtimeverification/haskell-backend#3684) will pass in CI here.
The changes cross a number of different projects, so just being overly cautious :)