-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update KRYPTO
hooks to use Bytes
instead of String
#3684
Conversation
Blocked on #3687 - the |
KRYPTO
hooks to use Bytes
instead of String
KRYPTO
hooks to use Bytes
instead of String
KRYPTO
hooks to use Bytes
instead of String
KRYPTO
hooks to use Bytes
instead of String
Holding off on actually merging this until I can locally test with KEVM and the booster |
@Scott-Guest Is this still blocked? This is blocking Semantics #2107 and I would like to get that one closed out as it has been aging in the backlog for quite a while. |
@yale-vinson Apologies, I had to shift to some higher-priority work in the middle of this. I have the bandwidth now and will prioritize getting this unblocked. |
KRYPTO
hooks to use Bytes
instead of String
KRYPTO
hooks to use Bytes
instead of String
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we need to modify stuff upstream once this is merged? If so, is everything else ready?
@goodlyrottenapple There are a number of changes needed upstream, but they're all trivial and/or ready to go:
|
Fixes #3683
The
KRYPTO
hooks now useBytes
for raw strings instead ofString
, so this PR updates the evaluators here accordingly.Additionally, I updated all tests that reference
KRYPTO
lest they give errors about hooked symbols having incorrect sorts. Specifically,regression-evm
tests by runninggenerate-regression-tests.sh
with my branch of KEVM that uses the updated hooks.KRYPTO
symbols into functions which wrap the new hooks with appropriate calls toString2Bytes
andBytes2String
.Corresponding PR testing this on the booster: runtimeverification/hs-backend-booster#370