Replacing shouldSave federation by a tracker class #2911
+52
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
An alternative is to create a new Tracker each time FederationStorageProvider fetches a new (old or pending) federation. If the federation should be saved, FederationStorageProvider may call a special constructor that sets the flag "modified" (previously shouldBeSaved). |
julia-zack
reviewed
Jan 2, 2025
rskj-core/src/main/java/co/rsk/peg/federation/FederationTracker.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Jan 2, 2025
rskj-core/src/main/java/co/rsk/peg/federation/FederationTracker.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Jan 2, 2025
rskj-core/src/main/java/co/rsk/peg/federation/FederationTracker.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Jan 2, 2025
rskj-core/src/main/java/co/rsk/peg/federation/FederationStorageProviderImpl.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Jan 2, 2025
rskj-core/src/main/java/co/rsk/peg/federation/FederationTracker.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Jan 2, 2025
rskj-core/src/main/java/co/rsk/peg/federation/FederationTracker.java
Outdated
Show resolved
Hide resolved
julia-zack
reviewed
Jan 2, 2025
rskj-core/src/main/java/co/rsk/peg/federation/FederationStorageProviderImpl.java
Outdated
Show resolved
Hide resolved
julianlen
force-pushed
the
bridge-federation-tracker
branch
from
0bfc14b to
75847c5
Compare
nathanieliov
reviewed
Jan 2, 2025
| @@ -146,13 +139,13 @@ public void setNewFederation(Federation federation) { | |||
|
|
|||
| @Override | |||
| public Federation getOldFederation(FederationConstants federationConstants, ActivationConfig.ForBlock activations) { | |||
| if (oldFederation != null || shouldSaveOldFederation) { | |||
| return oldFederation; | |||
| if (oldFederationTracker.isPresent() || oldFederationTracker.isModified()) { | |||
There was a problem hiding this comment.
Isn't the second condition here useless? What would be the case where oldFederationTracker is empty but isModified? It would return null, is it what we expect?
There was a problem hiding this comment.
It is, not clear the background but it is the expected behavior. If the method 'setFederation' is called passing null as a federation, it should keep the flag "isModified" as it was
apancorb
reviewed
Jan 3, 2025
rskj-core/src/main/java/co/rsk/peg/federation/FederationStorageProviderImpl.java
Outdated
Show resolved
Hide resolved
rskj-core/src/main/java/co/rsk/peg/federation/FederationTrackerImpl.java
Outdated
Show resolved
Hide resolved
rskj-core/src/main/java/co/rsk/peg/federation/FederationTracker.java
Outdated
Show resolved
Hide resolved
… the tracker, also merged setNew and replace into the same method using a parameter to clarify if it requires being saved or not
apancorb
reviewed
Jan 6, 2025
rskj-core/src/main/java/co/rsk/peg/federation/FederationTracker.java
Outdated
Show resolved
Hide resolved
julianlen
force-pushed
the
bridge-federation-tracker
branch
from
57822e0 to
af2e9c9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new class FederationTracker that tracks whether the federation must be saved (if it was modified)